sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Add Event Culture Context

Open philipphofmann opened this issue 4 years ago • 11 comments

With https://github.com/getsentry/develop/pull/329, we introduced culture context to our SDKs. Add it to the Java SDK.

We still need to wait until Discover supports culture_context (https://github.com/getsentry/sentry/issues/30525) before adding this.

This is related to https://github.com/getsentry/sentry-java/issues/1835.

philipphofmann avatar Dec 09 '21 10:12 philipphofmann

We're moving to Blocked since we depend on https://github.com/getsentry/sentry/issues/30525 or someone working actively on the 6.0 release.

marandaneto avatar Jan 12 '22 15:01 marandaneto

Hybrid SDKs need to ensure that this is not lost during serialization roundtrip, loop us in for testing. https://github.com/getsentry/sentry/issues/30525 is likely required as well otherwise the previous tags, filtering, etc will be gone.

marandaneto avatar May 22 '23 07:05 marandaneto

@marandaneto this is already implement on Cocoa, can you check that this is not lost when running on iOS?

romtsn avatar May 25 '23 13:05 romtsn

@marandaneto this is already implement on Cocoa, can you check that this is not lost when running on iOS?

Usually, this is a prob. on Android only due to the roundtrip, so iOS is safe.

marandaneto avatar May 25 '23 13:05 marandaneto

There's still no progress on backend though do we have to scope this into 7.0.0? I'd not like to depend on anything backend related to not get us blocked with the major

romtsn avatar May 25 '23 13:05 romtsn

@romtsn just deprecate the previous ones and start sending the new ones, this is how the other SDKs did, it's not a blocker this way.

marandaneto avatar May 25 '23 14:05 marandaneto