sentry-go icon indicating copy to clipboard operation
sentry-go copied to clipboard

Add zap integration

Open ribice opened this issue 11 months ago • 3 comments

Resolves #340 Closes GO-12

TODO:

  • [ ] Docs https://github.com/getsentry/sentry-docs/pull/12464
  • [ ] Add more tests
  • [ ] Add more examples

ribice avatar Jan 25 '25 19:01 ribice

Codecov Report

Attention: Patch coverage is 57.37052% with 107 lines in your changes missing coverage. Please review.

Project coverage is 82.41%. Comparing base (2e92c62) to head (7e3c24e). Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
zap/core.go 45.94% 65 Missing and 15 partials :warning:
zap/sentryzap.go 63.82% 16 Missing and 1 partial :warning:
zap/field.go 0.00% 4 Missing :warning:
zap/frame_matcher.go 71.42% 4 Missing :warning:
zap/util.go 94.73% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #958      +/-   ##
==========================================
- Coverage   83.63%   82.41%   -1.23%     
==========================================
  Files          49       54       +5     
  Lines        5139     5390     +251     
==========================================
+ Hits         4298     4442     +144     
- Misses        684      775      +91     
- Partials      157      173      +16     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jan 25 '25 19:01 codecov[bot]

hey is this PR expected to be merged in near future? or is it recommended to switch to another supported logging library that is already integrated with sentry?

aliBordbar1992 avatar Aug 16 '25 11:08 aliBordbar1992

Hey @aliBordbar1992, The PR only includes issue events and not logs, so it stills needs additional work. I would say for now it's better to switch to one of the supported integrations.

giortzisg avatar Aug 28 '25 11:08 giortzisg