sentry-go icon indicating copy to clipboard operation
sentry-go copied to clipboard

feat: http client integration

Open aldy505 opened this issue 1 year ago • 5 comments

An effort to implement this: https://develop.sentry.dev/sdk/telemetry/traces/modules/requests/

Since we already have tracing without performance, this should be good to go.

aldy505 avatar Aug 27 '24 02:08 aldy505

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 86.23%. Comparing base (c243873) to head (4cc9a92).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #876      +/-   ##
==========================================
+ Coverage   86.07%   86.23%   +0.16%     
==========================================
  Files          62       63       +1     
  Lines        6090     6148      +58     
==========================================
+ Hits         5242     5302      +60     
+ Misses        634      631       -3     
- Partials      214      215       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 27 '24 02:08 codecov[bot]

@aldy505 We should document this (in _examples, and perhaps sentry-docs?), and also update changelog accordingly.

ribice avatar Sep 03 '24 10:09 ribice

Some golint errors, I'll fix that later

aldy505 avatar Apr 23 '25 13:04 aldy505

@giortzisg @cleptric Is there anything that's blocking this PR to be merged?

aldy505 avatar May 12 '25 11:05 aldy505

Not sure we actually want to go the route with the round tripper. But we take another look after logs.

cleptric avatar May 12 '25 11:05 cleptric

@cleptric @giortzisg any updates?

aldy505 avatar Sep 25 '25 07:09 aldy505

Will have a look after transport refactoring.

giortzisg avatar Sep 25 '25 07:09 giortzisg

@giortzisg updated

aldy505 avatar Nov 30 '25 03:11 aldy505