sentry-go icon indicating copy to clipboard operation
sentry-go copied to clipboard

feat(performance): start transaction for echo middleware/integration

Open aldy505 opened this issue 2 years ago • 5 comments

Closes #642

Let me know if I should also edit CHANGELOG.md too.

aldy505 avatar Oct 01 '23 01:10 aldy505

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.76%. Comparing base (3c523e2) to head (988249a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
+ Coverage   81.59%   81.76%   +0.16%     
==========================================
  Files          48       48              
  Lines        4717     4759      +42     
==========================================
+ Hits         3849     3891      +42     
  Misses        728      728              
  Partials      140      140              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 01 '23 01:10 codecov[bot]

@aldy505 is there any news regarding the implementation? I could really use this

zKoz210 avatar Dec 27 '23 14:12 zKoz210

@aldy505 is there any news regarding the implementation? I could really use this

Michi (@cleptric) said to me a few weeks (or month?) ago over Discord that the Go SDK would need to prioritize to convert every performance section to use OpenTelemetry under the hood first before any other changes. That.. would mean this PR is on hold until the performance section is refactored.

Now, for you, would obviously not a good idea to wait for this PR to be merged. But one thing you can do is to copy and paste everything inside the echo directory (exclude the test, it's fine) to your project as your own "sentryecho" package. Then import your own "sentryecho" package instead of this one. I think that is doable on your part.

aldy505 avatar Dec 27 '23 14:12 aldy505

Since the perf by otel is on halt, here's a gentle ping @cleptric

aldy505 avatar Feb 27 '24 14:02 aldy505

I wanted to add starfish properties (or otel properties, really) as seen in #786, but I think it's better for this and #723 to be merged first, and I update #786 to include both echo and fasthttp. Or.. it can be a separate PR.

aldy505 avatar Mar 02 '24 00:03 aldy505

LGTM, thanks.

Any chance you could add a changelog entry?

@vaind in 3-4 hours from now

aldy505 avatar Mar 26 '24 10:03 aldy505

LGTM, thanks. Any chance you could add a changelog entry?

@vaind in 3-4 hours from now

I've noticed this repo doesn't have rules to prepare changelog in advance with PRs. Added #799 to fix that, afterwards we can add the entry in this PR.

vaind avatar Mar 26 '24 11:03 vaind