sentry-go icon indicating copy to clipboard operation
sentry-go copied to clipboard

fix: missing stack trace for parsing error in logrusentry

Open yiuiua opened this issue 1 year ago • 1 comments

fix #677

yiuiua avatar Aug 07 '23 14:08 yiuiua

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.01%. Comparing base (7b5b621) to head (c03711a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
- Coverage   82.06%   82.01%   -0.05%     
==========================================
  Files          49       49              
  Lines        4872     4844      -28     
==========================================
- Hits         3998     3973      -25     
+ Misses        732      730       -2     
+ Partials      142      141       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 09 '23 12:08 codecov[bot]

image

I added the changes from RFC 0079 (parent_id, exception_id and is_exception_group). Apart from that this PR fixed the issue with missing stacktrace.

Once #792 is merged as well, I'll create a common function for extracting errors and creating exceptions so that it's not rewritten wherever needed.

ribice avatar Mar 17 '24 17:03 ribice