sentry-go
sentry-go copied to clipboard
Add grpc unary server interceptor
This is a draft PR to support grpc (see #240). The main goal is to gather feedback and agree on the interface. Thus tests are not written yet. Any feedback/comments are welcomed. Thanks!
@rhcarvalho Added tests. Please take a look.
@rhcarvalho @spaceweasel Hi, it's been a while but could you take another look at this PR?
I was looking for this. Glad to see it's only a review away from getting it merged!
Hi, it's been some time since this has been open. Are there plans to merge this in?
@rhcarvalho @spaceweasel
This is exactly what I'm looking for. The pull request has been open for a while. Any chance this still can get a review? @rhcarvalho @spaceweasel
Any news?
Really looking forward to this getting merged!
Can't wait to see it's merged. This is exactly what I was looking for! Thanks a lot
Any updates. If it needs any help, i can do it.
Still relevant, please update status
Could this maybe be turned into a separate package if it's not going to be merged?
there's a seperate package here but code is not exactly same.
https://github.com/johnbellone/grpc-middleware-sentry
using this package until this PR merged can be a temporal solution.
This pull request has gone three weeks without activity. In another week, I will close it.
But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog
or Status: In Progress
, I will leave it alone ... forever!
"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀