sentry-go icon indicating copy to clipboard operation
sentry-go copied to clipboard

Add grpc unary server interceptor

Open shouichi opened this issue 3 years ago • 13 comments

This is a draft PR to support grpc (see #240). The main goal is to gather feedback and agree on the interface. Thus tests are not written yet. Any feedback/comments are welcomed. Thanks!

shouichi avatar Dec 18 '20 02:12 shouichi

@rhcarvalho Added tests. Please take a look.

shouichi avatar Jan 19 '21 06:01 shouichi

@rhcarvalho @spaceweasel Hi, it's been a while but could you take another look at this PR?

shouichi avatar Feb 16 '21 05:02 shouichi

I was looking for this. Glad to see it's only a review away from getting it merged!

becoded avatar Feb 26 '21 16:02 becoded

Hi, it's been some time since this has been open. Are there plans to merge this in?

@rhcarvalho @spaceweasel

odannyc avatar Apr 22 '21 21:04 odannyc

This is exactly what I'm looking for. The pull request has been open for a while. Any chance this still can get a review? @rhcarvalho @spaceweasel

Vesquen avatar Jul 06 '21 11:07 Vesquen

Any news?

koteesy avatar Jul 11 '21 11:07 koteesy

Really looking forward to this getting merged!

serbanmarti avatar Jul 14 '21 08:07 serbanmarti

Can't wait to see it's merged. This is exactly what I was looking for! Thanks a lot

legosx avatar Jul 20 '21 11:07 legosx

Any updates. If it needs any help, i can do it.

prasad-marne avatar Aug 20 '21 05:08 prasad-marne

Still relevant, please update status

pablodz avatar Oct 03 '21 03:10 pablodz

Could this maybe be turned into a separate package if it's not going to be merged?

flyte avatar Dec 08 '21 14:12 flyte

there's a seperate package here but code is not exactly same.

https://github.com/johnbellone/grpc-middleware-sentry

using this package until this PR merged can be a temporal solution.

HurSungYun avatar May 31 '22 02:05 HurSungYun

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Dec 07 '22 09:12 github-actions[bot]