sentry-go icon indicating copy to clipboard operation
sentry-go copied to clipboard

Add Fiber integration

Open arsmn opened this issue 3 years ago • 22 comments

Fiber integration

arsmn avatar Aug 23 '20 08:08 arsmn

@rhcarvalho

arsmn avatar Sep 19 '20 07:09 arsmn

@arsmn thanks for the contribution. Sorry we haven't had the bandwidth to review this yet. On a high level I expect this is pretty much the same as the fasthttp integration with types adapted to match fiber's.

I'll have a look at this and Buffalo (https://github.com/getsentry/sentry-go/pull/196) in the coming weeks, perhaps start moving integrations off into their own modules to avoid an ever increasing list of deps in the main go.mod file.

rhcarvalho avatar Sep 23 '20 08:09 rhcarvalho

@rhcarvalho gentle ping

akshaybabloo avatar Jan 25 '21 14:01 akshaybabloo

@rhcarvalho Can we please merge this ?

anistark avatar Feb 22 '21 10:02 anistark

Any updates on this? 💐

th0th avatar May 06 '21 00:05 th0th

any news?

alizaya avatar Aug 03 '21 19:08 alizaya

@rhcarvalho any update ?

ciazhar avatar Sep 27 '21 08:09 ciazhar

Any update?

efectn avatar Oct 04 '21 22:10 efectn

Would be nice if this was merged in with official support for Fiber and Sentry. Are there any issues @rhcarvalho?

pateljoel avatar Oct 06 '21 17:10 pateljoel

any update? plz

DuginKim avatar Oct 21 '21 02:10 DuginKim

Ping

NoobTW avatar Nov 07 '21 11:11 NoobTW

any update? plz

rodrigoodhin avatar Nov 10 '21 17:11 rodrigoodhin

Ping and Pong, please.

fcarvalhido avatar Nov 22 '21 09:11 fcarvalhido

not yet?

DuginKim avatar Dec 23 '21 05:12 DuginKim

not yet2?

@rhcarvalho @kamilogorek @benvinegar

DuginKim avatar Jan 04 '22 05:01 DuginKim

@arsmn thanks for the contribution. Sorry we haven't had the bandwidth to review this yet. On a high level I expect this is pretty much the same as the fasthttp integration with types adapted to match fiber's.

I'll have a look at this and Buffalo (#196) in the coming weeks, perhaps start moving integrations off into their own modules to avoid an ever increasing list of deps in the main go.mod file.

This is open for 1.5 years now. Is this still on the road map?

sebastianbuechler avatar Jan 12 '22 08:01 sebastianbuechler

I think @arsmn should create PR under the https://github.com/gofiber/contrib.

efectn avatar Jan 12 '22 08:01 efectn

Fiber integration is now available https://github.com/gofiber/contrib/tree/main/fibersentry Thank you all

arsmn avatar Jan 12 '22 23:01 arsmn

Hey @arsmn Are you still interested in getting this merged?

cleptric avatar Oct 30 '22 21:10 cleptric

Hey @cleptric & @arsmn any chance we could get this merged in? I'd love to have Sentry officially support this!

robd003 avatar Dec 20 '22 02:12 robd003

@robd003 Adding a Fiber integration is definitely on our road map, but I can't provide you with an ETA when this may land.

cleptric avatar Jan 09 '23 10:01 cleptric

@cleptric Kind reminder 🙏🏻

alfawal avatar Feb 21 '24 21:02 alfawal

Updated to work with the latest main branch in #795

vaind avatar Mar 26 '24 10:03 vaind

Thanks @arsmn for the contribution and sorry it took so long to get merged.

vaind avatar Mar 26 '24 10:03 vaind