sentry-go icon indicating copy to clipboard operation
sentry-go copied to clipboard

Stacktrace for functions from "go.*" will have incorrect package name

Open Pr0Ger opened this issue 5 years ago • 1 comments

https://github.com/getsentry/sentry-go/blob/4dddaaad5cc53f38de4928e98126dfbabd315423/stacktrace.go#L257-L262

This code as exptected will ignore parsing for functions which name starts from "go" however this is sometimes a valid package name. For example zap library: go.uber.org/zap/zapcore.(*CheckedEntry).Write will not properly extract go.uber.org/zap/zapcore as a package name.

Since this code is copied from debug/gosym I filled same issue for original code https://github.com/golang/go/issues/37762

Pr0Ger avatar Mar 09 '20 18:03 Pr0Ger

@Pr0Ger thanks for reporting here and upstream. I'll monitor what will happen upstream before we make changes here.

rhcarvalho avatar Mar 09 '20 20:03 rhcarvalho

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Dec 07 '22 09:12 github-actions[bot]