Option to filter `debug-files`

[farfromrefug]

trafficstars

I use the cli through the fastlane plugin for iOS https://github.com/getsentry/sentry-fastlane-plugin. when i do sentry_debug_files_upload:

sentry_debug_files_upload(
      url: ENV["SENTRY_URL"],
      org_slug: ENV["SENTRY_ORG"],
      project_slug: ENV["SENTRY_PROJECT"],
      wait: true,
      derived_data: false,
      include_sources: false,
      no_unwind: true,
      no_sources: true,
      upload_symbol_maps: true
    )

It detects a lot of debug files, some i want but also a lot i dont want for an iOS project on Macos, like .node files, files like ffi_c.bundle, libswiftos.dylib, sentry-cli-Darwin-universal, sentry-cli-Linux-x86_64, ....

It adds a lot of upload time, and server storage for nothing. A simple solution would be a filter parameter. The ideal thing would be for it to support an "array" of name or glob

[kahest]

transferring this to https://github.com/getsentry/sentry-fastlane-plugin - we should discuss there what we can do ootb to improve this and feed back to sentry-cli for adaptations if needed

[philipphofmann]

When looking at the upload command of sentry-cli there isn't currently a way to filter debug files to upload. I think we should first add this functionality to sentry-cli and then a parameter here. @szokeasaurusrex, do you think it's reasonable to add this to sentry-cli?

[szokeasaurusrex]

@philipphofmann that is correct, what I wanted to check first in the Fastlane plugin is whether perhaps we should be passing a more specific path to Sentry CLI. As in, maybe the files @farfromrefug is referring to are in a different directory which we should not be searching for debug files. If this is the case, then the requested filtering feature may not even be needed. Since the plugin passes the path to Sentry CLI, we could change this in the plugin.

If these files are in the same path as the debug symbols, then filtering is needed, and in that case, I agree that we should first implement the filtering in Sentry CLI.

[kahest]

@farfromrefug can you provide more information on how you use the fastlane-plugin, which folders do you provide?

[farfromrefug]

@kahest i dont provide a folder i let the plugin find them. I use it as i show up above. in my context the xcode project is in platforms/ios And it is an npm project so there is a node_modules folder (which could be where it finds many of files it reports)

[kahest]

@farfromrefug ah I see, thanks for clarifying - so you use it in conjunction with NativeScript I presume? We'll need to take a look at what the project folder structure looks like in that case and why/how the plugin picks up unwanted folders

[farfromrefug]

@kahest indeed i do it with Nativescript. Here is a sample project https://github.com/Akylas/conty Please let me know how i can help. Having first class fastlane support is really important for us

[kahest]

@farfromrefug thanks for the sample, that's helpful 🙏 I can't give an ETA, but if it's a smallish change, we might be able to squeeze it in

[github-actions[bot]]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[szokeasaurusrex]

@farfromrefug Have you tried manually passing the path to your debug files by using the path argument for sentry_debug_files_upload?

Providing the path explicitly might solve your problem, since the default is to search the entire project directory, which is likely too broad (I have raised this issue separately in #290).

[farfromrefug]

@farfromrefug Have you tried manually passing the path to your debug files by using the path argument for sentry_debug_files_upload?

Providing the path explicitly might solve your problem, since the default is to search the entire project directory, which is likely too broad (I have raised this issue separately in #290).

I havent tried. Will try when i can, however i already know it wont be sufficient. Might need to upload files from different directories so i have to use a "parent" directory which might include unwanted files (i dont have control over the file pattern). I think a filter (glob) would help solve that

[github-actions[bot]]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀