sentry-fastlane-plugin icon indicating copy to clipboard operation
sentry-fastlane-plugin copied to clipboard

Remove `sentry-cli` from the repository

Open bruno-garcia opened this issue 3 years ago • 8 comments

In this PR we've added more archictecutre/platform supports for sentry-cli:

  • https://github.com/getsentry/sentry-fastlane-plugin/pull/164/files

This will eventually bloat the repository significantly with the updates.

Proposed solution

Download sentry-cli on the first build. Check the checksum of the downloaded version against the checksum stored in the repo.

bruno-garcia avatar Sep 20 '22 14:09 bruno-garcia

@bruno-garcia I could take over this issue if you don't have anyone else in mind already.

denrase avatar Sep 20 '22 14:09 denrase

Please take it @denrase.

philipphofmann avatar Sep 21 '22 13:09 philipphofmann

Maybe we could apply a similar approach as we do in https://github.com/getsentry/sentry-dart-plugin/pull/49.

philipphofmann avatar Oct 06 '22 13:10 philipphofmann

We've agreed that downloading on the fly is actually an improvement since you don't bloat the repo and the user has to download only the needed binary, although, if it's working and it's not a source of complaints, we can prioritize more important issues, and this is eventually done when there are no more p1 for example. cc @denrase @kahest @philipphofmann

marandaneto avatar Oct 25 '22 07:10 marandaneto

I agree with lowering the priority for this issue.

philipphofmann avatar Oct 25 '22 07:10 philipphofmann

The idea is to download when packaging. Downloading on the user's machine has the downside of slowing down the first build,. Requiring internet access on the build time as opposed to "restore deps" phase; and brings security concerns (unless we pin ssl cert, which isn't good to maintain).

So the trade off is to check in the Sha in the repo and in CI when packaging, download the binary and verify the checksum. The final artifact will bundle it.

bruno-garcia avatar Nov 11 '22 04:11 bruno-garcia

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Dec 14 '22 00:12 github-actions[bot]