sentry-fastlane-plugin icon indicating copy to clipboard operation
sentry-fastlane-plugin copied to clipboard

Enha: support uploading multiple source map files simultaneously

Open mikkopiu opened this issue 3 years ago • 1 comments

Closes #141

Thanks for the plugin! I noticed the same issue as in #141 and would like to drop our custom shell script step, so here's a quick enhancement for that. I'm a Ruby-noob so let me know if something here should be done differently.

Some cases, such as when using Hermes builds with React Native on Android, require uploading both the bundle file and its corresponding source map simultaneously to be correctly processed by Sentry.

To avoid breaking backwards compatbility, use the same singular argument name but accept both string and array values.

mikkopiu avatar Jul 29 '22 08:07 mikkopiu

@denrase since you're our fastlane specialist, can you take a look at this?

brustolin avatar Aug 03 '22 06:08 brustolin

Thanks for the review, I'll check these next week!

mikkopiu avatar Aug 25 '22 17:08 mikkopiu

Simplified implementation as per review, fixed style issues, added one more tests to also cover the comma-separated list case and updated changelog. LMK if there's something else to fix!

mikkopiu avatar Aug 29 '22 12:08 mikkopiu