sentry-dotnet icon indicating copy to clipboard operation
sentry-dotnet copied to clipboard

Add default metrics

Open jamescrosswell opened this issue 1 year ago • 4 comments

There are various metrics that have already been instrumented in .NET which users might be interested in sending to Sentry:

We'll likely resolve this issue in multiple Pull Requests:

  • [ ] https://github.com/getsentry/sentry-dotnet/pull/3052
  • [ ] https://github.com/getsentry/sentry-dotnet/pull/3100

jamescrosswell avatar Jan 09 '24 09:01 jamescrosswell

Furthermore, the Polly.Extensions package now provides seamless integration with IServiceCollection and facilitates the export of Polly’s telemetry events into .NET metrics.

https://devblogs.microsoft.com/dotnet/building-resilient-cloud-services-with-dotnet-8/

maybe something interesting to tap into

bruno-garcia avatar Jan 13 '24 02:01 bruno-garcia

See Built in Metrics

I think we can tap into these using the MeterListner API.

jamescrosswell avatar Jan 16 '24 07:01 jamescrosswell

Added FirstChanceException to the list (I recall we talked about it but I couldn't find a ticket)

bruno-garcia avatar Jan 16 '24 20:01 bruno-garcia

Added FirstChanceException to the list (I recall we talked about it but I couldn't find a ticket)

Yeah I remember discussing it. Were we just thinking of a counter for that one (# of first chance exceptions)?

jamescrosswell avatar Jan 16 '24 21:01 jamescrosswell

I wanted to double check that sampling of Observable instruments (eg ObservableCounter) is on the radar for this? Just had a play with the experimental feature and noticed it wasn't reporting any of the observable instruments yet (MeterListener.RecordObservableInstruments is never invoked)

We are otherwise looking forward to trying out Metrics with Sentry

optical avatar Jul 22 '24 04:07 optical

I wanted to double check that sampling of Observable instruments (eg ObservableCounter) is on the radar for this?

It is now!

bitsandfoxes avatar Jul 22 '24 09:07 bitsandfoxes