sentry-dotnet
sentry-dotnet copied to clipboard
getsentry
Capture errors through IAsyncExceptionFilter
Microsoft docs: IAsyncExceptionFilter
This is something Abp captures, and when using Sentry, Sentry doesn't.
See: https://github.com/abpframework/abp/issues/17581
Should Sentry be capturing this OOTB?
Wouldn't that try to catch the same exceptions that our middleware currently captures? So you'd catch it once in the exceptionfilter (for exceptions eminating from the API layer) and once again in the middleware?
If so, then I guess it would give a way to capture exceptions in frameworks that leverage ExceptionFilters but don't utilize middleware. Although at least in the case of Abp, it looks like the Sentry's logging integration would provide a mechanism to capture exceptions (since Abp logs the exceptions it captures through it's ExceptionFilter).
I guess I'm wondering what the upside to implementing an IAsyncExceptionFilter would be? Would it enable us to instrument things with Sentry that people can't already instrument with what we provide?
