sentry-dotnet icon indicating copy to clipboard operation
sentry-dotnet copied to clipboard

Replace "Unknown Route" with the raw URL and a transaction annotation

Open bruno-garcia opened this issue 3 years ago • 3 comments

Problem Statement

The spec now allows to send raw URLs when they are annotated so the server can take that into account:

https://develop.sentry.dev/sdk/event-payloads/transaction/#transaction-annotations

Solution Brainstorm

We can rely on that and replace the current "Unknown Route" sent by the ASP.NET Core integration which isn't very helpful.

This is a change worthy of landing on the next major. Since a lot of new transactions will show up in Sentry. Today they'd be grouped under one things and going forward they'd rely on Sentry's ability to group them well (even though it'll be based on heuristics)

bruno-garcia avatar Jul 19 '22 20:07 bruno-garcia

So, we should send only route when we have it, but otherwise send url and don't send "unknown route" ever.

mattjohnsonpint avatar Jul 20 '22 21:07 mattjohnsonpint

I think we can do this without waiting for 4.x, but we should note the behavior change in the changelog.

mattjohnsonpint avatar Jul 20 '22 21:07 mattjohnsonpint

Note, this change will be visible to almost everyone that uses .UseSentryTracing() in ASP.Net Core for performance monitoring, as it will stop grouping 404s in the same way.

mattjohnsonpint avatar Jul 20 '22 21:07 mattjohnsonpint

@bruno-garcia any thoughts on the comment from @mattjohnsonpint ?

SimonCropp avatar Aug 18 '22 21:08 SimonCropp