sentry-dotnet icon indicating copy to clipboard operation
sentry-dotnet copied to clipboard

Remove `before.Sentry.sln.targets` in favor of using `ValidateSolutionConfiguration`

Open bruno-garcia opened this issue 3 years ago • 1 comments

In order to restore git submodule before running the first build through dotnet build, ideally we'd hook into ValidateSolutionConfiguration. That wasn't possible (see https://github.com/dotnet/msbuild/issues/6452) so as a work around we added before.Sentry.sln.targets to the repo.

Once the fix ships on msbuild/.NET SDK, remove before.Sentry.sln.targets in favor of using ValidateSolutionConfiguration

bruno-garcia avatar Jun 05 '21 14:06 bruno-garcia

Instead of relying on a solution-based configuration, which doesn't get triggered when you build individual projects, e.g. dotnet build samples/...., we could maybe use this: https://git-scm.com/docs/git-config#Documentation/git-config.txt-submodulerecurse (@jamescrosswell linked this a while back on Discord)

vaind avatar Dec 04 '23 14:12 vaind