sentry-docs icon indicating copy to clipboard operation
sentry-docs copied to clipboard

Sentry integration code generated in the documentation for koa is using deprecated methods

Open michaelwiles opened this issue 1 year ago • 6 comments

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. Go to https://docs.sentry.io/platforms/node/guides/koa/#monitor-performance
  2. See the generated integration code for koa
  3. Copy and paste that code into your project

Expected Result

Deprecated code messages should not be present

Actual Result

Deprecated code references are present.

Product Area

Help

Link

https://docs.sentry.io/platforms/node/guides/koa/#monitor-performance

DSN

No response

Version

No response

michaelwiles avatar Jan 26 '24 07:01 michaelwiles

Assigning to @getsentry/support for routing ⏲️

getsantry[bot] avatar Jan 26 '24 07:01 getsantry[bot]

Routing to @getsentry/product-owners-settings-integrations for triage ⏲️

getsantry[bot] avatar Jan 26 '24 17:01 getsantry[bot]

Assigning to @getsentry/support for routing ⏲️

getsantry[bot] avatar Jan 26 '24 18:01 getsantry[bot]

Routing to @getsentry/product-owners-sdks-web-frontend for triage ⏲️

getsantry[bot] avatar Jan 26 '24 18:01 getsantry[bot]

Hi @michaelwiles - PRs are welcome, otherwise we are backlogging this to tackle as soon as we are done some of our other changes.

Deprecated methods should work fine for now - they were only recently deprecated in the last few minor versions of the SDK.

AbhiPrasad avatar Jan 26 '24 18:01 AbhiPrasad

Generally, for this specific thing I think it's not worth it to refactor this deprecated code, because this will be completely changed in v8, when we can rely on OpenTelemetry for koa instrumentation. So keep an eye out for v8, where you hopefully won't have to manually instrument your koa app for performance anymore.

mydea avatar Feb 01 '24 08:02 mydea