fix: sentry_transaction_start takes 2 arguments

Open loewenheim opened this issue 3 years ago • 1 comments

As pointed out in https://github.com/getsentry/sentry-docs/issues/5568, sentry_transaction_start takes 2 arguments, but is called in multiple places in the docs with just one argument. The documentation of sentry_transaction_start says

The second parameter is a custom Sampling Context to be used with a Traces
Sampler to make a more informed sampling decision. The SDK does not currently
support a custom Traces Sampler and this parameter is ignored for the time
being but needs to be provided.

Therefore I think we should just add sentry_value_new_null as the second argument everywhere.

Fixes https://github.com/getsentry/sentry-docs/issues/5568.

Oct 05 '22 15:10 loewenheim

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
sentry-docs	✅ Ready (Inspect)	Visit Preview	Oct 14, 2022 at 5:13PM (UTC)

Oct 05 '22 15:10 vercel[bot]