sentry-docs icon indicating copy to clipboard operation
sentry-docs copied to clipboard

Correct Order of sentry-cli release finalize vs deploy command

Open cyberguard opened this issue 3 years ago • 2 comments

Core or SDK?

Platform/SDK

Which part? Which one?

sentry-cli

Description

Do we need to finalize a release before we use sentry-cli deploys or is finalized call when the release is deployed to production ?

i.e. is this sequence the right one (Which is hinted by https://docs.sentry.io/product/releases/setup/ )

sentry-cli releases new $BUILD_VERSION
sentry-cli releases files $BUILD_VERSION upload-sourcemaps public/packs --url-prefix '~/packs'
sentry-cli deploys -p XXX-frontend #{latest_revision} new  -e preprod # On Tuesday we deploy version to preprod
sentry-cli deploys -p XXX-frontend #{latest_revision} new  -e prod  # On Wed, qa is ok we deploy version to prod
sentry-cli releases finalize $BUILD_VERSION

or is it this one, where we finalize the release before the deploy (Which is what https://docs.sentry.io/product/cli/releases/#finalizing-releases shows )

sentry-cli releases new $BUILD_VERSION
sentry-cli releases files $BUILD_VERSION upload-sourcemaps public/packs --url-prefix '~/packs'
sentry-cli releases finalize $BUILD_VERSION
sentry-cli deploys -p XXX-frontend #{latest_revision} new  -e preprod # On Tuesday we deploy version to preprod
sentry-cli deploys -p XXX-frontend #{latest_revision} new  -e prod  # On Wed, qa is ok we deploy version to prod

Thanks!

Suggested Solution

No suggestion, excep to wait for your answer :)

cyberguard avatar Aug 27 '22 23:08 cyberguard

Routing to @getsentry/infrastructure for triage. ⏲️

getsentry-release avatar Aug 31 '22 18:08 getsentry-release

Hey, finalization doesn't affect deploys so both orders will work the same way.

kamilogorek avatar Sep 12 '22 14:09 kamilogorek

Since the ordering is irrelevant, according to the comment above, we can close this issue

szokeasaurusrex avatar Apr 19 '24 11:04 szokeasaurusrex