getsentry
Update hermes docs to use bundled hermesc script
Since React Native 0.69 hermes has been bundled with React Native.
If users use the old hermesc version from node_modules/hermes-engine the version won't match.
This PR recommends users to change their hermes script to use the the hermesc version from react-native if they are using React Native 0.69 or later:
// OS-BIN is osx-bin, win64-bin, or linux64-bin, depending on which operating system you are using
node_modules/react-native/sdks/hermesc/{OS-BIN}/hermesc
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
@SMJ93 is attempting to deploy a commit to the Sentry Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| sentry-docs | ✅ Ready (Inspect) | Visit Preview | Sep 9, 2022 at 2:19PM (UTC) |
It looks like some of what you've added is already covered in a note just before step 3, but the folks on @getsentry/team-mobile will need to check this for technical accuracy. After that, I'll review for wording and structure.
It looks like some of what you've added is already covered in a note just before step 3, but the folks on @getsentry/team-mobile will need to check this for technical accuracy. After that, I'll review for wording and structure.
Hi @imatwawana,
Yeah, that is quite hidden away - it is also better to explain why it has changed (see the link to react native blog).
Maybe a better alternative would be to flip the default to React Native 0.69 and keep the note for 0.68 and below?
It looks like some of what you've added is already covered in a note just before step 3, but the folks on @getsentry/team-mobile will need to check this for technical accuracy. After that, I'll review for wording and structure.
Hi @imatwawana,
Yeah, that is quite hidden away - it is also better to explain why it has changed (see the link to react native blog).
Maybe a better alternative would be to flip the default to React Native 0.69 and keep the note for 0.68 and below?
I'll definitely defer to the @getsentry/team-mobile team on the best way to approach this.
I'd say we keep this open till more people adopt the 0.69.x version, right now the majority of our users are not there yet.
The note below mentions 0.69.x support, what we can do is to move the note above the command, what do you think @imatwawana ?
@imatwawana Do you want me to update this PR or do you want to close and create a new one?
Oh sorry, I just realized that bumps into the recommendation that @marandaneto had made. Let's leave this one open and I'll open a new PR (#5467) to move the note. I'll circle back and make some suggestions on this PR to get it ready for when we can use it down the road.
Hey @imatwawana, can this be merged?
Per @marandaneto's comment before, we're gonna hold off on merging until more folks have adopted the newer version: https://github.com/getsentry/sentry-docs/pull/5455#issuecomment-1231336075 @marandaneto, please merge this whenever it makes sense.
Hey @imatwawana, can this be merged?
Per @marandaneto's comment before, we're gonna hold off on merging until more folks have adopted the newer version: #5455 (comment) @marandaneto, please merge this whenever it makes sense.
React Native 0.69 has been out for nearly 3 months and 0.70 was released this week.
I assume most people who are setting up sentry will be using versions 0.69 and 0.70?
@imatwawana @marandaneto any update with this?
Sentry RN SDK v5 is still alpha (currently working on it), also the adoption of RN >= 0.70 is very low, any reason why you would like to push this? the docs already state which commands to run on the older and newer version.
@marandaneto the adoption rate of 0.69+ is pretty high which includes the bundled version of hermes.
Chasing as I created this PR nearly 3 months ago.
Feel free to close if you are updating the cods as part of v5.
@marandaneto Maybe we can make this change independent of RN SDK v5 as v4 users can use v4 with 0.69+ if they make changes described in the troubleshooting page.
@krystofwoldrich @marandaneto This is probably out of date now as RN 0.71 has just been released - feel free to close
@krystofwoldrich adjust the text if necessary and merge it since RN 0.7x is already stable.