sentry-docs icon indicating copy to clipboard operation
sentry-docs copied to clipboard

Formatting problem for Issue Stats note

Open sdzhong opened this issue 2 years ago • 2 comments

Core or SDK?

Core Sentry product

Which part? Which one?

https://docs.sentry.io/product/stats/#issue-stats

Description

The note for Issue Stats

This feature is available only if your organization is on a Business plan. Is not rendering properly.

image

Suggested Solution

I'm expecting the note to appear the same as the note in Health Stats https://docs.sentry.io/product/stats/#health-stats image

sdzhong avatar Aug 22 '22 20:08 sdzhong

I'm fairly certain this is related to our overall linking issues in docs right now. Related to issues #4580, #4915, and #5321. I'm going to open a parent issue so link all of these to.

imatwawana avatar Aug 22 '22 21:08 imatwawana

Rather than creating a new parent issue, I've just linked all of these issues to issue 4580 and I'll keep tracking them there.

imatwawana avatar Aug 25 '22 18:08 imatwawana

Tracking this problem on this issue. Related issues: #5569 #5867 (closed as dupe)

imatwawana avatar Dec 19 '22 14:12 imatwawana

This has something to do with the gastby-remark-terms plugin, maybe @untitaker knows more?

You can tell if you look at the generated DOM image

It's put the whole note inside a term-wrapper. The only place that is defined is here https://github.com/getsentry/sentry-docs/blob/48dfe316e3fcfc360328b379f5bd579969665540/src/gatsby/plugins/gatsby-remark-terms/index.js#L121

That said it appears to have a slightly different structure, so it's not totally clear what's going on here

evanpurkhiser avatar May 31 '23 18:05 evanpurkhiser

It works fine if I disable javascript in my browser, it's another hydration thing

untitaker avatar Jun 05 '23 18:06 untitaker

Seems fixed now

stephanie-anderson avatar Feb 23 '24 11:02 stephanie-anderson