sentry-docs icon indicating copy to clipboard operation
sentry-docs copied to clipboard

Details about Automatically Instrumented Tags per SDK

Open sdzhong opened this issue 3 years ago • 13 comments

Core or SDK?

Core Sentry product

Which part? Which one?

/enriching-events/tags/

Description

Some tags are captured by the SDK automatically and some are set explicitly (e.g. with Sentry.setTag or Sentry.setUser). I propose having the default tags listed in their appropriate SDK docs.

Suggested Solution

For SDK guides' /enriching-events/tags/ pages (e.g. https://docs.sentry.io/platforms/react-native/enriching-events/tags/, https://docs.sentry.io/platforms/php/guides/laravel/enriching-events/tags/), include a section on tags that are Automatically Instrumented by its Sentry SDK.

sdzhong avatar Feb 04 '22 00:02 sdzhong

Failed to route to Team: Web Platform. 😕

Defaulting to @getsentry/open-source for triage. ⏲️

getsentry-release avatar Feb 04 '22 14:02 getsentry-release

Routing to @getsentry/team-mobile for triage. ⏲️

getsentry-release avatar Feb 04 '22 14:02 getsentry-release

Routing to @getsentry/team-mobile for triage. ⏲️

getsentry-release avatar Feb 04 '22 14:02 getsentry-release

@getsentry/team-mobile & @getsentry/team-mobile - Does this seem like something we could work on together to start building? Is this something that's a reasonable ask and lift to maintain? I'm happy to coordinate the effort if this makes sense to pursue.

imatwawana avatar Feb 04 '22 14:02 imatwawana

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Feb 25 '22 18:02 github-actions[bot]

Bump.

chadwhitacre avatar Feb 25 '22 18:02 chadwhitacre

Seems like a generic issue for all the SDKs and not Mobile only, deferring that to the Docs team.

marandaneto avatar Feb 26 '22 07:02 marandaneto

Seems like a generic issue for all the SDKs and not Mobile only, deferring that to the Docs team.

Looks like there was an error in my initial comment. I meant to address my comments to the @getsentry/team-web-frontend, @getsentry/team-web-backend, and @getsentry/team-mobile teams, since I would need the actual content to come from you all. Does this seem like something you all could make time to help with to get started and reasonable to maintain over time?

imatwawana avatar Feb 28 '22 15:02 imatwawana

@imatwawana yes, but I believe SDKs don't set tags automatically, some tags are created automatically tho during event ingestion, so the Ingest team would know better.

marandaneto avatar Feb 28 '22 15:02 marandaneto

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Mar 22 '22 00:03 github-actions[bot]

@getsentry/owners-ingest bump

imatwawana avatar Mar 22 '22 13:03 imatwawana

hi, i don't think we got notified for this issue. some tags are automatically created in ingest for sure, but some sdks also set tags automatically afaik. so i think the list of derived tags we could set up similarly to how Configuration Options is defined per-platform

on the other hand, I think the broader ask here is which fields can be searched for, and that's a more complicated question to answer. It also depends on which data the SDK extracts in the first place.

For example, if I were to document that geo.country_code is a derived tag, for certain platforms this means absolutely nothing because the relevant data (ip-address) is not sent at all.

anyway that's the thoughts i have on this for now.. a more clearly defined scope for documenting things would help

untitaker avatar Mar 22 '22 14:03 untitaker

@sdzhong is there anything more you can add here in response to @untitaker's comment?

imatwawana avatar Mar 25 '22 15:03 imatwawana

Closing since this became stale and there was an open question.

jan-auer avatar Jan 20 '23 14:01 jan-auer