sentry-docs icon indicating copy to clipboard operation
sentry-docs copied to clipboard

feat(platform): Display requested title in platform redirect

Open chargome opened this issue 1 year ago • 4 comments

closes https://github.com/getsentry/sentry-docs/issues/10517

With this change we display the title and description of the requested page (if it exists).

before

Screenshot 2024-10-24 at 13 02 44

after

Screenshot 2024-10-24 at 12 58 33

The risk here is that different platforms might have different titles and descriptions for the same page, and in this PR we just take the first one we find (which is usually .NET I think). I tested out some pages and it seemed to work fine every time.

chargome avatar Oct 24 '24 11:10 chargome

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 11:18am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 11:18am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 11:18am

vercel[bot] avatar Oct 24 '24 11:10 vercel[bot]

Bundle Report

Changes will increase total bundle size by 158 bytes (0.0%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.37MB 215 bytes (0.0%) :arrow_up:
sentry-docs-edge-server-array-push 333.11kB 3 bytes (-0.0%) :arrow_down:
sentry-docs-client-array-push 6.44MB 54 bytes (-0.0%) :arrow_down:

codecov[bot] avatar Oct 24 '24 11:10 codecov[bot]

Oh, how fast! Thanks for implementing this. I initially thought we would add the page titles and descriptions in the list of platforms (instead of .NET etc), but this is also an option. Would let @lizokm decide on what she would prefer

stephanie-anderson avatar Oct 24 '24 11:10 stephanie-anderson

@stephanie-anderson yeah I just went with lizas most recent comment in the connected issue

chargome avatar Oct 24 '24 11:10 chargome