sentry-docs icon indicating copy to clipboard operation
sentry-docs copied to clipboard

feat(platform): Navigation buttons

Open chargome opened this issue 1 year ago • 5 comments

closes https://github.com/getsentry/sentry-docs/issues/11572

chargome avatar Oct 23 '24 10:10 chargome

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 0:19am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 0:19am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 0:19am

vercel[bot] avatar Oct 23 '24 10:10 vercel[bot]

Bundle Report

Changes will increase total bundle size by 5.14kB (0.04%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.52MB 4.45kB (0.06%) :arrow_up:
sentry-docs-edge-server-array-push 257.08kB 3 bytes (-0.0%) :arrow_down:
sentry-docs-client-array-push 6.44MB 693 bytes (0.01%) :arrow_up:

codecov[bot] avatar Oct 23 '24 10:10 codecov[bot]

Haven't had the chance to check - I think this is not up to date with master. Have we checked if hidden pages are properly excluded from that navigation? I can think of the metrics page in develop docs as a good example:

Screenshot 2024-10-23 at 17 53 19

stephanie-anderson avatar Oct 23 '24 15:10 stephanie-anderson

@stephanie-anderson this is up to date with master, metrics is not excluded – or maybe I don't understand the question 🤔

chargome avatar Oct 24 '24 08:10 chargome

Oh, this page was never hidden in the first place 🙈 I was referring to whether we checked if the frontmatter config sidebar_hidden would be properly respected (as in, it would never be a previous or next page suggestion)

stephanie-anderson avatar Oct 24 '24 08:10 stephanie-anderson