sentry-docs icon indicating copy to clipboard operation
sentry-docs copied to clipboard

Setting the text highlight colour to transparent breaks accessibility

Open whitep4nth3r opened this issue 1 year ago • 8 comments

Steps to Reproduce

  1. Attempt to highlight some text (copy text, not code samples) on the docs page
  2. Observe that you can't see what text you have highlighted
  3. This is due to the webkit-tap-highlight colour being set to transparent

Expected Result

I should be able to see what text I have highlighted if I have done so.

Actual Result

image

Additional Info

No response

whitep4nth3r avatar Jun 07 '24 08:06 whitep4nth3r

Assigning to @getsentry/support for routing ⏲️

getsantry[bot] avatar Jun 07 '24 08:06 getsantry[bot]

Does this happen on iOS @whitep4nth3r ?

a-hariti avatar Jun 10 '24 11:06 a-hariti

This is happening for me on MacOS in Arc browser.

I can highlight correctly on iOS.

whitep4nth3r avatar Jun 10 '24 11:06 whitep4nth3r

I'm not sure I understand / can repro the issue @whitep4nth3r screenshot with Arc on Mac os (both in desktop and mobile mode)

image

a-hariti avatar Jun 10 '24 11:06 a-hariti

That's strange. I've turned off all my browser extensions and I still can't highlight text.

I've tried in Safari and I can highlight in that browser, so it's not to do with my system settings.

I'm on Arc Version 1.46.0 (50665).

whitep4nth3r avatar Jun 10 '24 11:06 whitep4nth3r

I'm on the exact same version

a-hariti avatar Jun 10 '24 11:06 a-hariti

I can reproduce this in Safari on https://docs.sentry.io/platforms/javascript/guides/express/ on the instrument.js sample, only when logged in.

danielcompton avatar Jun 25 '24 01:06 danielcompton

I'm now on the following version of Arc on desktop:

Version 1.48.2 (51225)
Chromium Engine Version 126.0.6478.115

And I can highlight text when logged in and when logged out.

I'm not sure what's happening here!

However, regarding logged in/logged out behaviour and I think I found a different bug.

Should the nav bar item for "sign in" change to something else when you are signed in?

whitep4nth3r avatar Jun 25 '24 07:06 whitep4nth3r

Image

stephanie-anderson avatar Jul 29 '24 15:07 stephanie-anderson

@stephanie-anderson you've cracked the case. This is exactly why I was experiencing this 🫠

whitep4nth3r avatar Jul 29 '24 15:07 whitep4nth3r