sentry-dart icon indicating copy to clipboard operation
sentry-dart copied to clipboard

Package Analysis step in CI does not upload results for contributors

Open ueman opened this issue 3 years ago • 2 comments

From https://github.com/getsentry/sentry-dart/runs/6113791214?check_suite_focus=true

Warning: It seems that this action doesn't have the required permissions to call the GitHub API with the token you gave. This can occur if this repository is a fork, as in that case GitHub reduces the GITHUB_TOKEN's permissions for security reasons. Consequently, no report will be made on GitHub. Check this issue for more information: https://github.com/axel-op/dart-package-analyzer/issues/2

ueman avatar Apr 21 '22 14:04 ueman

@ueman that's fine, it does not fail because of that tho, it fails because of https://github.com/dart-lang/pana/issues/1020 It's still useful to run pana from forks, or do you mean something else?

marandaneto avatar Apr 22 '22 08:04 marandaneto

The issue is, that a contributer doesn't really know what's wrong if it fails because the result isn't uploaded.

ueman avatar Apr 22 '22 09:04 ueman

I'm voting to close this - the CI job prints failure to logs - all the info is there for contributors to see and fix. Yes, it's not easy to read, but it's actionable. This could maybe be improved in the dependent action if it is really troublesome to many people but I wouldn't track it in this repo.

vaind avatar Nov 07 '22 13:11 vaind