sentry-dart icon indicating copy to clipboard operation
sentry-dart copied to clipboard

Allow attachments to be bound to exception more easily

Open fzyzcjy opened this issue 4 years ago • 1 comments

Fixs #682

fzyzcjy avatar Dec 26 '21 14:12 fzyzcjy

Codecov Report

Base: 89.47% // Head: 89.46% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (47690cc) compared to base (5a6e8fc). Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
- Coverage   89.47%   89.46%   -0.01%     
==========================================
  Files         106      106              
  Lines        3326     3333       +7     
==========================================
+ Hits         2976     2982       +6     
- Misses        350      351       +1     
Impacted Files Coverage Δ
dart/lib/src/sentry_options.dart 87.50% <ø> (ø)
dart/lib/src/hub.dart 80.70% <90.00%> (+0.21%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Dec 26 '21 14:12 codecov-commenter

https://github.com/getsentry/sentry-dart/pull/1136 is going to enable this type of feature, which is passing or removing attachments from the hint.

marandaneto avatar Nov 18 '22 08:11 marandaneto

Closing, the new approach should use hints

marandaneto avatar Jan 26 '23 12:01 marandaneto