sentry-dart icon indicating copy to clipboard operation
sentry-dart copied to clipboard

Add module for stack frames

Open ueman opened this issue 8 months ago • 2 comments

Problem Statement

I would like to have the module be reported to Sentry. Right now, that's not done as seen here:

https://github.com/getsentry/sentry-dart/blob/bc3ad3c691cee925a540e972eb893a958ebf53d2/dart/lib/src/sentry_stack_trace_factory.dart#L135-L143

Given a stackframe like package:app_name/features/picking/ui/view_model/picking_item_view_model.dart:213 I would expect this app_name/features/picking/ui/view_model part to be the module.

I'm not quite sure of the impact of adding that now, so I would need some guidance here. I would also assume, that the module should only be added for frames with a package at the start due to privacy concerns.

Solution Brainstorm

Parse the module for a stack frame and send it to the backend.

Are you willing to submit a PR?

Yes

ueman avatar May 12 '25 11:05 ueman

This is specifically for non-obfuscated builds right?

I'm not quite sure of the impact of adding that now, so I would need some guidance here.

I just checked and changing it doesn't affect grouping which is good.

Any specific reason though you need it? afaict the Sentry UI doesn't highlight it at all, you can only see it if you open the json

buenaflor avatar May 12 '25 12:05 buenaflor

This is specifically for non-obfuscated builds right?

Yes, exactly.

Any specific reason though you need it?

I want to be able to use the stack.module filter in the search, so that I can see every exception that comes from a specific folder (module).

ueman avatar May 12 '25 12:05 ueman