sentry-dart icon indicating copy to clipboard operation
sentry-dart copied to clipboard

Android exception aggregate

Open ueman opened this issue 1 year ago • 1 comments

:scroll: Description

Example: https://jonas-uekotter.sentry.io/share/issue/bd0cdbab9fef4bd8bfffe13517c77288/

@buenaflor @krystofwoldrich @denrase

I'm not 100% sure whether the result of the changes in this PR is correct, could you double-check whether it's correct? After that, I'll add some tests

:bulb: Motivation and Context

https://github.com/getsentry/rfcs/blob/main/text/0079-exception-groups.md

Another tiny step towards https://github.com/getsentry/sentry-dart/issues/1859

:green_heart: How did you test it?

TBD

:pencil: Checklist

  • [ ] I reviewed submitted code
  • [ ] I added tests to verify changes
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • [ ] I updated the docs if needed
  • [ ] All tests passing
  • [ ] No breaking changes

:crystal_ball: Next steps

ueman avatar Apr 19 '24 11:04 ueman

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.57%. Comparing base (ee0ca56) to head (610d006). Report is 383 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1999      +/-   ##
==========================================
- Coverage   95.30%   92.57%   -2.73%     
==========================================
  Files          54       58       +4     
  Lines        1789     1967     +178     
==========================================
+ Hits         1705     1821     +116     
- Misses         84      146      +62     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 19 '24 11:04 codecov[bot]

@ueman we'd like to do the exception grouping in the v9 branch, do you wanna continue this? if not I can take over

buenaflor avatar Feb 13 '25 13:02 buenaflor

Feel free to take this over. I guess the idea should be clear and it's just a matter of executing it

ueman avatar Feb 13 '25 14:02 ueman

closing this then and will continue on the v9 branch

buenaflor avatar Feb 14 '25 15:02 buenaflor