getsentry
Redact Screenshots via View Hierarchy
We have Screenshots, and we have View Hierarchy. For Mobile SR, we use VH to redact SS-based Replays - we should "backport" this functionality to the SS feature.
Rationale: SS can contain PII and other sensitive information, therefore the feature is not viable for some use cases and orgs. Redacting SS via VH enables wider adoption and improves experience for those who already use it.
Let's evaluate:
- Implement screeshot redacting and use it for session replay later
- Wait for session replay and reuse its implementation for SS and VH
Hi @The-RootCause thanks for your interest - it's very likely we will implement this in the next few months, we'll keep this issue updated with any progress
I would love to help contribute this feature since we also need this in our app.
This was brought to my attention by @buenaflor yesterday...
We already have screenshot redacting implemented for replay. As soon as #2208 is merged, the code can be adapted/reused for standard screenshots too.
See WidgetFilter which walks the tree and creates a list of bounding rectangles to redact. Then it's just the question of painting them onto the screenshot
@vaind do you know the rough timeline for SR? I was thinking if it makes sense to use the WidgetFilter implementation now outside of the SR branch so we can already implement it for screenshots
@vaind do you know the rough timeline for SR? I was thinking if it makes sense to use the
WidgetFilterimplementation now outside of the SR branch so we can already implement it for screenshots
I want to make another pre-released today, now that sentry-java has shipped with an update we need. If all goes well, we can merge replay branch to main & still keep it as an alpha feature (i.e. subject to change), since there doesn't seem to be any immediate issue that would require us to roll back these changes. That was the only reason for keeping another branch alive.
See WidgetFilter which walks the tree and creates a list of bounding rectangles to redact. Then it's just the question of painting them onto the screenshot
This is now merged to main so this issue is unblocked
@martinhaintz I've noticed you've assigned this to yourself. Just be aware there will be changes in the replay redaction logic (thus also in screenshot reduction) in order to support user-configurable widget-level redaction
Not sure how far along @martinhaintz is. If he hasn't started yet then yeah, I think it makes sense to deprioritize this for now. If a lot of work is already done on screenshot redacting (I haven't found a PR though) then maybe it makes sense to finish and merge that and I'll fit it together with the changes I'm preparing
@vaind Sorry, for interrupting your plan. As @buenaflor was on vacation, I spoke with @kahest and he assigned it to me via chat.
I currently have no working code and therefore have not created a branch yet. I haven't invested too much time yet. I started with the issue today.
So I will stop working on it since you are already kind of working on it.
