sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

Use NXGetLocalArchInfo again to report device architecture

Open philipphofmann opened this issue 4 years ago • 4 comments

With https://github.com/getsentry/sentry-cocoa/issues/635, a user reported that Apple marked NXGetLocalArchInfo as a private API. This stopped him from releasing his app. FirebaseCrashlytics had a similar issue with https://github.com/firebase/firebase-ios-sdk/issues/6128. We merged a PR to remove the usage of NXGetLocalArchInfo https://github.com/getsentry/sentry-cocoa/pull/651. Firebase didn't take any action and they reported that they didn't receive any reports since September, see https://github.com/firebase/firebase-ios-sdk/issues/6128#issuecomment-758200172.

Maybe we can undo our PR https://github.com/getsentry/sentry-cocoa/pull/651 to report the architecture for the device again.

For reference: #652

philipphofmann avatar Jan 13 '21 13:01 philipphofmann

Architecture is being reported properly:

image

bruno-garcia avatar Jan 18 '21 15:01 bruno-garcia

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Nov 08 '21 09:11 github-actions[bot]

Crashlytics still uses it here https://github.com/firebase/firebase-ios-sdk/blob/bdac2b87f6d6e604deae914a970a75136b3a62b5/Crashlytics/Shared/FIRCLSMachO/FIRCLSMachO.m#L250. Make sure it's actually used on iOS. Also, check KSCrash. Do this to make sure that readding the usage of NXGetLocalArchInfo doesn't prevent users from submitting their apps to the App Store.

philipphofmann avatar Jan 05 '22 15:01 philipphofmann

KSCrash does have its own routine using sysctl, here it is in the Sentry fork: https://github.com/getsentry/sentry-cocoa/blob/60455bdb4572a4c1e4b604cc1735a3195730939f/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_System.m#L275-L310

I also was just working on this same problem for profiling purposes, which is how I stumbled on this related set of issues. See this draft PR: https://github.com/getsentry/sentry-cocoa/pull/2205

armcknight avatar Sep 21 '22 07:09 armcknight