sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

ref: Use CryptoKit instead of CommonCrypto in SentryDsn

Open github-actions[bot] opened this issue 1 week ago • 1 comments

[!NOTE] The pull request "ref: Use CryptoKit instead of CommonCrypto in SentryDsn" was created by @antonis but did not reference an issue. Therefore this issue was created for better visibility in external tools like Linear.

:scroll: Description

:bulb: Motivation and Context

See https://github.com/getsentry/sentry-cocoa/pull/6942#discussion_r2605973827

This is a swift improvement as a follow up to the above review feedback. It is not required thus feel free to reject/close the PR if the (breaking) change is not desired.

:green_heart: How did you test it?

  • Manual
  • Added unit tests

:pencil: Checklist

You have to check all boxes before merging:

  • [x] I added tests to verify the changes.
  • [x] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [x] I updated the wizard if needed.
  • [x] Review from the native team if needed.
  • [x] No breaking change or entry added to the changelog.
  • [x] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

#skip-changelog

github-actions[bot] avatar Dec 12 '25 12:12 github-actions[bot]

COCOA-1085

linear[bot] avatar Dec 12 '25 12:12 linear[bot]

I've closed the linked PR since without bumping the minimum MacOS version the refactoring is not possible. We can revisit as an improvement later.

antonis avatar Dec 16 '25 08:12 antonis

I will close this issue, as we will not do this for at least another year. At least we have it documented now and issues search should bring it up again when searching for CryptoKit

philprime avatar Dec 16 '25 09:12 philprime