ref: Use CryptoKit instead of CommonCrypto in SentryDsn
[!NOTE] The pull request "ref: Use CryptoKit instead of CommonCrypto in SentryDsn" was created by @antonis but did not reference an issue. Therefore this issue was created for better visibility in external tools like Linear.
:scroll: Description
- Use
CryptoKitinstead ofCommonCryptoinSentryDsn - ⚠️ Bumps the macOS target from
10.14to10.15that theInsecure.SHA1from CryptoKit requires
:bulb: Motivation and Context
See https://github.com/getsentry/sentry-cocoa/pull/6942#discussion_r2605973827
This is a swift improvement as a follow up to the above review feedback. It is not required thus feel free to reject/close the PR if the (breaking) change is not desired.
:green_heart: How did you test it?
- Manual
- Added unit tests
:pencil: Checklist
You have to check all boxes before merging:
- [x] I added tests to verify the changes.
- [x] No new PII added or SDK only sends newly added PII if
sendDefaultPIIis enabled. - [ ] I updated the docs if needed.
- [x] I updated the wizard if needed.
- [x] Review from the native team if needed.
- [x] No breaking change or entry added to the changelog.
- [x] No breaking change for hybrid SDKs or communicated to hybrid SDKs.
#skip-changelog
I've closed the linked PR since without bumping the minimum MacOS version the refactoring is not possible. We can revisit as an improvement later.
I will close this issue, as we will not do this for at least another year. At least we have it documented now and issues search should bring it up again when searching for CryptoKit