sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

fix: Outdated app launch comment

Open noahsmartin opened this issue 1 week ago • 2 comments

Looks like I forgot to change this comment when I removed the UIWindow notification approach in V9

#skip-changelog

Closes #7035

noahsmartin avatar Dec 12 '25 01:12 noahsmartin

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 85.271%. Comparing base (83cd14a) to head (fb9a28c). :warning: Report is 11 commits behind head on main. :white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #7034       +/-   ##
=============================================
+ Coverage   85.070%   85.271%   +0.200%     
=============================================
  Files          454       458        +4     
  Lines        27737     28156      +419     
  Branches     12157     12464      +307     
=============================================
+ Hits         23596     24009      +413     
+ Misses        4096      3889      -207     
- Partials        45       258      +213     

see 70 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 83cd14a...fb9a28c. Read the comment docs.

codecov[bot] avatar Dec 12 '25 01:12 codecov[bot]

Can you link the related PR in the comments here?

itaybre avatar Dec 12 '25 01:12 itaybre

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1225.22 ms 1249.56 ms 24.34 ms
Size 24.14 KiB 1.03 MiB 1.00 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c6c1cb7d7d79c8282ade9d70df5cba040f971f86 1235.71 ms 1263.80 ms 28.08 ms
83265fc140230a75c9d37f7599a44213e495adae 1212.33 ms 1242.31 ms 29.98 ms
27e751429a201e0ab9a12330b403b51dc31a6c06 1229.47 ms 1245.60 ms 16.13 ms
996b9970722e21dda07dda625982b2863464ddbd 1188.71 ms 1209.36 ms 20.65 ms
be8375a51ec16d753936189b9a26af1e76337648 1212.65 ms 1239.72 ms 27.08 ms
1b15a2acaa46f1d56b0e5b59fc0660b9e520149d 1227.13 ms 1254.80 ms 27.66 ms
6cb43388f0fa691d5ae466615a2882a6f52e7d8d 1238.47 ms 1256.96 ms 18.49 ms
b714cb902ce18db268292707fb098d03786e8cc9 1224.71 ms 1238.04 ms 13.33 ms
59fc426a4007de5417de66c3c73fb96286ef5b03 1240.49 ms 1256.94 ms 16.45 ms
00d97404946a37e983eabb21cc64bd3d5d2cb474 1223.53 ms 1249.75 ms 26.22 ms

App size

Revision Plain With Sentry Diff
c6c1cb7d7d79c8282ade9d70df5cba040f971f86 23.75 KiB 928.15 KiB 904.40 KiB
83265fc140230a75c9d37f7599a44213e495adae 23.75 KiB 1022.78 KiB 999.03 KiB
27e751429a201e0ab9a12330b403b51dc31a6c06 23.75 KiB 919.69 KiB 895.94 KiB
996b9970722e21dda07dda625982b2863464ddbd 24.14 KiB 1.01 MiB 1012.94 KiB
be8375a51ec16d753936189b9a26af1e76337648 23.75 KiB 933.03 KiB 909.28 KiB
1b15a2acaa46f1d56b0e5b59fc0660b9e520149d 24.14 KiB 1.01 MiB 1013.56 KiB
6cb43388f0fa691d5ae466615a2882a6f52e7d8d 23.75 KiB 913.63 KiB 889.88 KiB
b714cb902ce18db268292707fb098d03786e8cc9 23.75 KiB 858.69 KiB 834.93 KiB
59fc426a4007de5417de66c3c73fb96286ef5b03 23.75 KiB 920.64 KiB 896.89 KiB
00d97404946a37e983eabb21cc64bd3d5d2cb474 23.75 KiB 938.32 KiB 914.57 KiB

github-actions[bot] avatar Dec 15 '25 23:12 github-actions[bot]