sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

fix: Development builds with prebuilt binary

Open noahsmartin opened this issue 3 weeks ago • 3 comments

The only way this would ever report debug is if the code was built with the DEBUG preprocessor flag. But we support building from a pre-built binary which is pre-built in release mode (I hope) so this would not work. A more reliable way is to check the entitlements to see if it's a debug build.

#skip-changelog

Closes #6990

noahsmartin avatar Dec 04 '25 15:12 noahsmartin

Codecov Report

:x: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 7.064%. Comparing base (b2295d4) to head (bf18975). :warning: Report is 1 commits behind head on main. :white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ces/Swift/Helper/SentryMobileProvisionParser.swift 0.000% 5 Missing :warning:
...ash/Recording/Monitors/SentryCrashMonitor_System.m 0.000% 3 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (b2295d4) and HEAD (bf18975). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (b2295d4) HEAD (bf18975)
4 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #6989        +/-   ##
=============================================
- Coverage   85.076%   7.064%   -78.013%     
=============================================
  Files          453      418        -35     
  Lines        27674    26415      -1259     
  Branches     12166     9921      -2245     
=============================================
- Hits         23544     1866     -21678     
- Misses        4087    24536     +20449     
+ Partials        43       13        -30     
Files with missing lines Coverage Δ
...ash/Recording/Monitors/SentryCrashMonitor_System.m 70.512% <0.000%> (-1.470%) :arrow_down:
...ces/Swift/Helper/SentryMobileProvisionParser.swift 0.000% <0.000%> (-82.858%) :arrow_down:

... and 434 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b2295d4...bf18975. Read the comment docs.

codecov[bot] avatar Dec 04 '25 15:12 codecov[bot]

Codecov Report

:x: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 7.064%. Comparing base (b2295d4) to head (bf18975). :warning: Report is 1 commits behind head on main. :white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ces/Swift/Helper/SentryMobileProvisionParser.swift 0.000% 5 Missing :warning:
...ash/Recording/Monitors/SentryCrashMonitor_System.m 0.000% 3 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (b2295d4) and HEAD (bf18975). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (b2295d4) HEAD (bf18975)
4 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #6989        +/-   ##
=============================================
- Coverage   85.076%   7.064%   -78.013%     
=============================================
  Files          453      418        -35     
  Lines        27674    26415      -1259     
  Branches     12166     9921      -2245     
=============================================
- Hits         23544     1866     -21678     
- Misses        4087    24536     +20449     
+ Partials        43       13        -30     
Files with missing lines Coverage Δ
...ash/Recording/Monitors/SentryCrashMonitor_System.m 70.512% <0.000%> (-1.470%) :arrow_down:
...ces/Swift/Helper/SentryMobileProvisionParser.swift 0.000% <0.000%> (-82.858%) :arrow_down:

... and 434 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b2295d4...bf18975. Read the comment docs.

codecov[bot] avatar Dec 04 '25 16:12 codecov[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1224.87 ms 1244.18 ms 19.31 ms
Size 24.14 KiB 1.02 MiB 1020.91 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
37900c9774fbb4ab5895c9ce43775ef1dd4faef0 1236.06 ms 1262.22 ms 26.16 ms
929c622bffdad079548aaa380b51d7cc346cadca 1228.48 ms 1253.55 ms 25.07 ms
48e5c8a5aeeb44c7fa4f348b6db6be53f1a19099 1223.02 ms 1242.38 ms 19.35 ms
a5981056669e34e7c69cb0e48dc1211b5f28b393 1236.51 ms 1258.88 ms 22.37 ms
319fb1e2637db1e5a235d5217e3973666d7a51e7 1219.48 ms 1242.69 ms 23.21 ms
e98d6f52277fd00c8af98e907ec5afe260a057e6 1228.51 ms 1258.85 ms 30.34 ms
daeb71695c6c029e1c8e8c6a74d96f672fc4655a 1215.41 ms 1246.52 ms 31.11 ms
cd67f528cb32230ec9347b8d1c133fc0a1371824 1216.29 ms 1255.27 ms 38.99 ms
e8e40fdf38ee60c8f4e0c19770d0cef33cf1deb8 1222.10 ms 1259.91 ms 37.80 ms
78af7a98184554ac39e9fc833bb3d330914f8647 1225.75 ms 1256.98 ms 31.23 ms

App size

Revision Plain With Sentry Diff
37900c9774fbb4ab5895c9ce43775ef1dd4faef0 23.75 KiB 958.61 KiB 934.85 KiB
929c622bffdad079548aaa380b51d7cc346cadca 24.14 KiB 1.02 MiB 1016.90 KiB
48e5c8a5aeeb44c7fa4f348b6db6be53f1a19099 23.75 KiB 913.63 KiB 889.88 KiB
a5981056669e34e7c69cb0e48dc1211b5f28b393 23.75 KiB 968.24 KiB 944.49 KiB
319fb1e2637db1e5a235d5217e3973666d7a51e7 23.75 KiB 1019.18 KiB 995.43 KiB
e98d6f52277fd00c8af98e907ec5afe260a057e6 23.75 KiB 933.03 KiB 909.28 KiB
daeb71695c6c029e1c8e8c6a74d96f672fc4655a 23.75 KiB 928.16 KiB 904.41 KiB
cd67f528cb32230ec9347b8d1c133fc0a1371824 23.75 KiB 1.01 MiB 1016.04 KiB
e8e40fdf38ee60c8f4e0c19770d0cef33cf1deb8 23.75 KiB 1022.79 KiB 999.04 KiB
78af7a98184554ac39e9fc833bb3d330914f8647 23.75 KiB 990.00 KiB 966.26 KiB

github-actions[bot] avatar Dec 04 '25 16:12 github-actions[bot]