[WIP] ref: SentryEnvelopeHeader to swift
Blocked by https://github.com/getsentry/sentry-cocoa/pull/5453
Converts SentryEnvelopeHeader to Swift
#skip-changelog
Codecov Report
:x: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 86.756%. Comparing base (93c76b0) to head (7f1c719).
:warning: Report is 7 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| Sources/Sentry/SentryEnvelope.m | 80.000% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #5454 +/- ##
=============================================
+ Coverage 86.625% 86.756% +0.130%
=============================================
Files 427 428 +1
Lines 36870 36901 +31
Branches 15807 17419 +1612
=============================================
+ Hits 31939 32014 +75
+ Misses 4891 4842 -49
- Partials 40 45 +5
| Files with missing lines | Coverage Δ | |
|---|---|---|
| Sources/Sentry/SentryClient.m | 98.944% <100.000%> (+0.004%) |
:arrow_up: |
| Sources/Sentry/SentryTransportAdapter.m | 100.000% <100.000%> (ø) |
|
| Sources/Swift/Tools/SentryEnvelopeHeader.swift | 100.000% <100.000%> (ø) |
|
| Sources/Sentry/SentryEnvelope.m | 87.037% <80.000%> (-1.803%) |
:arrow_down: |
... and 22 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 93c76b0...7f1c719. Read the comment docs.
Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 1217.00 ms | 1235.96 ms | 18.96 ms |
| Size | 23.75 KiB | 947.71 KiB | 923.96 KiB |
Baseline results on branch: main
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| effeafa3422d4f571659ddecf6c36f527b80f45d | 1225.88 ms | 1249.78 ms | 23.90 ms |
| 21375302b4c2afa2366ee8726a3a428feff3f082 | 1223.39 ms | 1253.25 ms | 29.86 ms |
| 5d238d36df08c29f7c2d6e448530c2ff4d02da14 | 1228.94 ms | 1253.04 ms | 24.10 ms |
| efa740d79f6dadae7856c274c5c673e462d82a58 | 1220.71 ms | 1246.20 ms | 25.50 ms |
| d157d83ca63eb1c3b1b899d109ef9a1094ac4770 | 1228.02 ms | 1252.47 ms | 24.45 ms |
| 5db87fadf4c77a122640220412fe7c704f60fb47 | 1218.88 ms | 1251.53 ms | 32.65 ms |
| 139db8b9769c008210310800d3b8d39e7c5fe27c | 1231.50 ms | 1258.19 ms | 26.69 ms |
| 83bb97844b3d6332a45b423eff67beac3be3ff78 | 1238.33 ms | 1260.04 ms | 21.71 ms |
| 891fd1d4209c595516927d48ed677a2917a7bf64 | 1220.02 ms | 1227.60 ms | 7.57 ms |
| 2de3f92ef65432cb85855b449fff3513c07ae428 | 1207.56 ms | 1234.96 ms | 27.40 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| effeafa3422d4f571659ddecf6c36f527b80f45d | 23.74 KiB | 926.64 KiB | 902.89 KiB |
| 21375302b4c2afa2366ee8726a3a428feff3f082 | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| 5d238d36df08c29f7c2d6e448530c2ff4d02da14 | 23.75 KiB | 913.62 KiB | 889.88 KiB |
| efa740d79f6dadae7856c274c5c673e462d82a58 | 23.75 KiB | 919.69 KiB | 895.95 KiB |
| d157d83ca63eb1c3b1b899d109ef9a1094ac4770 | 23.75 KiB | 928.85 KiB | 905.10 KiB |
| 5db87fadf4c77a122640220412fe7c704f60fb47 | 23.75 KiB | 926.65 KiB | 902.90 KiB |
| 139db8b9769c008210310800d3b8d39e7c5fe27c | 23.75 KiB | 920.64 KiB | 896.89 KiB |
| 83bb97844b3d6332a45b423eff67beac3be3ff78 | 23.75 KiB | 920.64 KiB | 896.89 KiB |
| 891fd1d4209c595516927d48ed677a2917a7bf64 | 23.75 KiB | 919.92 KiB | 896.17 KiB |
| 2de3f92ef65432cb85855b449fff3513c07ae428 | 23.75 KiB | 919.69 KiB | 895.94 KiB |
Previous results on branch: envelopeHeaderSwift
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1532434ad074589f06b9247355bd077913e40146 | 1231.52 ms | 1259.47 ms | 27.95 ms |
| fdf2ea80235978055648a415fa073a1b50ab6107 | 1218.63 ms | 1251.82 ms | 33.18 ms |
| cbea941cbde596907d9d276af9fdfc1cb8c2b37d | 1237.08 ms | 1259.14 ms | 22.06 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1532434ad074589f06b9247355bd077913e40146 | 23.75 KiB | 947.72 KiB | 923.97 KiB |
| fdf2ea80235978055648a415fa073a1b50ab6107 | 23.75 KiB | 858.40 KiB | 834.64 KiB |
| cbea941cbde596907d9d276af9fdfc1cb8c2b37d | 23.75 KiB | 947.72 KiB | 923.97 KiB |
🚨 Detected changes in high risk code 🚨
High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
- [x] Sources/Sentry/SentrySerialization.m