fix: Stacktrace symbolication of fatal app hangs
:scroll: Description
Add debug images for all app hang events directly in the ANRTrackingIntegration to ensure all app hang events have debug images attached, which is required for symbolication.
:bulb: Motivation and Context
Fixes GH-5433
:green_heart: How did you test it?
Unit tests and with TestFlight
Fatal app hang event before the fix from the iOS-Swift sample app via TestFlight
https://sentry-sdks.sentry.io/issues/6690874496/events/da915f043c0741959b04d9ce9ba42943/?project=5428557
With the fix
https://sentry-sdks.sentry.io/issues/6695548079/events/934bb93490554023905e9570cc78c75a/?project=5428557
:pencil: Checklist
You have to check all boxes before merging:
- [x] I added tests to verify the changes.
- [x] No new PII added or SDK only sends newly added PII if
sendDefaultPIIis enabled. - [x] I updated the docs if needed.
- [x] I updated the wizard if needed.
- [x] Review from the native team if needed.
- [x] No breaking change or entry added to the changelog.
- [x] No breaking change for hybrid SDKs or communicated to hybrid SDKs.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.214%. Comparing base (
8c7114c) to head (9276d2d). Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #5438 +/- ##
=============================================
- Coverage 86.217% 86.214% -0.003%
=============================================
Files 399 399
Lines 34652 34652
Branches 14991 14986 -5
=============================================
- Hits 29876 29875 -1
Misses 4734 4734
- Partials 42 43 +1
| Files with missing lines | Coverage Δ | |
|---|---|---|
| Sources/Sentry/SentryANRTrackingIntegration.m | 99.378% <100.000%> (+0.007%) |
:arrow_up: |
... and 6 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 8c7114c...9276d2d. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 1232.24 ms | 1254.11 ms | 21.87 ms |
| Size | 23.75 KiB | 847.21 KiB | 823.46 KiB |
Baseline results on branch: main
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9faf2175dbc03d57307202d15fea3b0581fb47aa | 1268.86 ms | 1274.82 ms | 5.96 ms |
| b5bcbab6ba2deba5b1e3aa2d76b0491be34e7981 | 1222.24 ms | 1243.20 ms | 20.96 ms |
| b1b7d72a698a580149d8d0c91218f3ff532d79f7 | 1246.31 ms | 1261.00 ms | 14.69 ms |
| 83acf3e57a9b03bdde1f89988946d38cfbf79495 | 1240.06 ms | 1261.38 ms | 21.31 ms |
| 8ef07fb048bd862c61aecee28e7b0e80c33ca926 | 1231.45 ms | 1243.98 ms | 12.53 ms |
| a9103fe09dcaa2f8b814062b46a8b6f59692df55 | 1221.49 ms | 1243.33 ms | 21.84 ms |
| 7f691b5344ddcfd55da954cc56722e2109751f03 | 1233.94 ms | 1243.80 ms | 9.86 ms |
| 81c218773ab43837a3f510e34f426197b60c748d | 1224.20 ms | 1252.68 ms | 28.48 ms |
| 676e429128a264d3ac61c2e90e26149580495fec | 1225.76 ms | 1235.49 ms | 9.73 ms |
| 7054676e7fd4843e8b924d48e8b59173e8476efe | 1229.46 ms | 1246.40 ms | 16.94 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9faf2175dbc03d57307202d15fea3b0581fb47aa | 20.76 KiB | 419.70 KiB | 398.94 KiB |
| b5bcbab6ba2deba5b1e3aa2d76b0491be34e7981 | 23.75 KiB | 846.99 KiB | 823.24 KiB |
| b1b7d72a698a580149d8d0c91218f3ff532d79f7 | 20.76 KiB | 436.33 KiB | 415.57 KiB |
| 83acf3e57a9b03bdde1f89988946d38cfbf79495 | 21.58 KiB | 539.87 KiB | 518.29 KiB |
| 8ef07fb048bd862c61aecee28e7b0e80c33ca926 | 21.58 KiB | 707.42 KiB | 685.84 KiB |
| a9103fe09dcaa2f8b814062b46a8b6f59692df55 | 20.76 KiB | 426.95 KiB | 406.19 KiB |
| 7f691b5344ddcfd55da954cc56722e2109751f03 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
| 81c218773ab43837a3f510e34f426197b60c748d | 21.58 KiB | 736.53 KiB | 714.94 KiB |
| 676e429128a264d3ac61c2e90e26149580495fec | 21.58 KiB | 614.73 KiB | 593.15 KiB |
| 7054676e7fd4843e8b924d48e8b59173e8476efe | 21.58 KiB | 542.28 KiB | 520.70 KiB |
Previous results on branch: fix/fatal-app-hang-symbolication
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8ff79957fe4e97b3d5dc5735ceff428ddb7ed999 | 1205.73 ms | 1225.47 ms | 19.73 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8ff79957fe4e97b3d5dc5735ceff428ddb7ed999 | 23.75 KiB | 847.20 KiB | 823.45 KiB |