sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard
verified publisher icon getsentry

Change rate limiting logs to level warning or error

Open philipphofmann opened this issue 1 year ago • 2 comments

Description

See https://github.com/getsentry/team-mobile/issues/195.

philipphofmann avatar Oct 17 '24 17:10 philipphofmann

Hey @philipphofmann ! I was wondering if the goal is just to update the log-level here to something like SENTRY_LOG_WARN(@"RateLimit is active for all envelope items.") (as the title of this issue states) or also have some additional log statement, which isn't bound to the condition that all items has to be rate-limited in order to print the log?

I've the first variant ready in a fork, let me know if I should open a PR.

SentryHttpTransportTests
Image

rwachtler avatar Oct 20 '24 14:10 rwachtler

I think we should also log a warning here to communicate that one envelope item of the envelope was dropped. https://github.com/getsentry/sentry-cocoa/blob/fc350a451fe35646984e94b69ada9e6d0544e022/Sources/Sentry/SentryHttpTransport.m#L229-L237

Yes, feel free to open a PR, @rwachtler. We will help you to merge it.

philipphofmann avatar Oct 21 '24 14:10 philipphofmann