sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

feat(user feedback): initial API

Open armcknight opened this issue 1 year ago • 2 comments

An initial draft of the API we'll offer to customers for the new User Feedback widget and managed form, for https://github.com/getsentry/sentry-cocoa/issues/4269, including an example of how it would look to configure it, in iOS-Swift.

Docs PR: https://github.com/getsentry/sentry-docs/pull/11191

#skip-changelog

armcknight avatar Aug 15 '24 20:08 armcknight

Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against ebb7c99fa5d406b39af1fe80b3c725bf1f0754e5

github-actions[bot] avatar Aug 15 '24 20:08 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 86 lines in your changes missing coverage. Please review.

Project coverage is 91.556%. Comparing base (c45c91c) to head (ebb7c99). Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...uration/SentryUserFeedbackThemeConfiguration.swift 0.000% 30 Missing :warning:
...s/UserFeedback/SentryUserFeedbackIntegration.swift 0.000% 28 Missing :warning:
...guration/SentryUserFeedbackFormConfiguration.swift 0.000% 20 Missing :warning:
...ration/SentryUserFeedbackWidgetConfiguration.swift 0.000% 5 Missing :warning:
...onfiguration/SentryUserFeedbackConfiguration.swift 0.000% 3 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4284       +/-   ##
=============================================
- Coverage   91.697%   91.556%   -0.142%     
=============================================
  Files          622       627        +5     
  Lines        50502     50616      +114     
  Branches     18251     18347       +96     
=============================================
+ Hits         46309     46342       +33     
- Misses        4102      4182       +80     
- Partials        91        92        +1     
Files with missing lines Coverage Δ
Sources/Sentry/SentrySDK.m 88.950% <ø> (ø)
...onfiguration/SentryUserFeedbackConfiguration.swift 0.000% <0.000%> (ø)
...ration/SentryUserFeedbackWidgetConfiguration.swift 0.000% <0.000%> (ø)
...guration/SentryUserFeedbackFormConfiguration.swift 0.000% <0.000%> (ø)
...s/UserFeedback/SentryUserFeedbackIntegration.swift 0.000% <0.000%> (ø)
...uration/SentryUserFeedbackThemeConfiguration.swift 0.000% <0.000%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c45c91c...ebb7c99. Read the comment docs.

codecov[bot] avatar Aug 15 '24 20:08 codecov[bot]

Also adding @c298lee and @billyvg from the Replay team (they are familiar with the Feedback SDK in JS)

bruno-garcia avatar Sep 16 '24 14:09 bruno-garcia

automatic behavior like poping up a modal on crash or on shake

@bruno-garcia I do have the shake trigger in here already, but popping a dialog on crash detection is a good one too 👍🏻 Though I'd echo @philipphofmann 's comment to keep scope narrow for v1 and follow on with that.

armcknight avatar Sep 18 '24 22:09 armcknight

Pushed a commit to remove this from public access while we merge intermediate PRs

armcknight avatar Sep 19 '24 20:09 armcknight