sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

Add `breadrumb.origin`

Open krystofwoldrich opened this issue 1 year ago • 1 comments

Description

Description

Add new runtime property to SentryBreadcrumb called origin, this can be used to identify source of the breadcrumb.

For example hybrid SDKs can identify native breadcrumbs from JS or Flutter.

### Required for
- [ ] https://github.com/getsentry/sentry-capacitor/pull/629
- [ ] https://github.com/getsentry/sentry-react-native/issues/2146 

Related issues

  • https://github.com/getsentry/sentry-java/issues/3470

krystofwoldrich avatar Jun 10 '24 08:06 krystofwoldrich

@lucas-zimerman When you open a PR , you can link this issue.

krystofwoldrich avatar Jun 10 '24 08:06 krystofwoldrich

Please update the develop docs before closing this issue.

philipphofmann avatar Sep 24 '24 13:09 philipphofmann

Hey @philipphofmann 👋 thank you for the heads up 🙇 Since the new field is private for internal use my understanding is that we don't need to add it in the developer docs. Let me know if this is not the case 🙏

antonis avatar Sep 26 '24 10:09 antonis

@antonis, it's still part of the protocol. The developer docs are for SDK maintainers. You don't have to do that, but either @krystofwoldrich, who opened the issue, or one of the Sentry folks should do it.

philipphofmann avatar Sep 27 '24 06:09 philipphofmann

Makes sense. Thank you for the feedback Philipp 🙇 I'm reopening the issue till this is tackled.

antonis avatar Sep 27 '24 07:09 antonis

Opened a PR updating the documentation that would close this issue https://github.com/getsentry/sentry-docs/pull/11449

antonis avatar Sep 27 '24 07:09 antonis