sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard
verified publisher icon getsentry

Uptake of KSCrash bug fixes

Open armcknight opened this issue 1 year ago • 1 comments

Description

While reviewing https://github.com/getsentry/sentry-cocoa/pull/3895, I searched for a similar bugfix in KSCrash and found it. It got me thinking about how we might have bugs in the crash reporter that have since been fixed upstream.

Did we ever have a process to apply newer patches from upstream onto the code we copied into the SDK?

There have been 180 commits since we originally added the KSCrash source code to the SDK:

KSCrash on master
❯ git log --oneline --after '2018-06-20' | wc -l
     180

armcknight avatar Apr 25 '24 01:04 armcknight

I follow the KSCrash repo and apply patches if I see anything useful. A year ago or so, I once skimmed through all the patches and applied the useful ones to our repository, but we don't have a formal process or so no, mostly because the repo isn't really active anymore.

philipphofmann avatar Apr 25 '24 13:04 philipphofmann

I think we can close this, as we have all the patches applied from there. See https://github.com/getsentry/sentry-cocoa/issues/3900#issuecomment-2077240167.

philipphofmann avatar May 22 '24 12:05 philipphofmann