sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

ref: Use average color for redact masking

Open brustolin opened this issue 10 months ago • 2 comments

Use the text color or the average color of the image as the redaction mask.

#skip-changelog

brustolin avatar Apr 23 '24 08:04 brustolin

Codecov Report

Attention: Patch coverage is 98.54227% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 90.823%. Comparing base (aa45f36) to head (7589760). Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3877       +/-   ##
=============================================
+ Coverage   90.690%   90.823%   +0.132%     
=============================================
  Files          581       586        +5     
  Lines        45418     45778      +360     
  Branches     16162     16334      +172     
=============================================
+ Hits         41190     41577      +387     
- Misses        4048      4131       +83     
+ Partials       180        70      -110     
Files Coverage Δ
Sources/Sentry/SentrySessionReplay.m 87.179% <100.000%> (+0.424%) :arrow_up:
Sources/Sentry/SentrySessionReplayIntegration.m 91.666% <ø> (ø)
...egrations/SessionReplay/SentryOnDemandReplay.swift 97.435% <ø> (+1.709%) :arrow_up:
...tions/SessionReplay/SentrySessionReplayTests.swift 98.333% <100.000%> (-0.028%) :arrow_down:
Tests/SentryTests/RedactRegionTests.swift 100.000% <100.000%> (ø)
Tests/SentryTests/UIImageHelperTests.swift 100.000% <100.000%> (ø)
Tests/SentryTests/UIRedactBuilderTests.swift 100.000% <100.000%> (ø)
Sources/Swift/Tools/UIRedactBuilder.swift 98.780% <98.780%> (ø)
Sources/Swift/Tools/SentryViewPhotographer.swift 88.888% <87.500%> (+31.076%) :arrow_up:
Sources/Swift/Tools/UIImageHelper.swift 87.500% <87.500%> (ø)

... and 49 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aa45f36...7589760. Read the comment docs.

codecov[bot] avatar Apr 23 '24 14:04 codecov[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1241.67 ms 1253.83 ms 12.16 ms
Size 21.58 KiB 619.21 KiB 597.63 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
1e065bcccc0572b03c44fa943cd9e6080e42c820 1239.69 ms 1258.18 ms 18.49 ms
6f4d20cfd596b993e8ef9c1ebdeb5c835cb612be 1228.67 ms 1238.88 ms 10.21 ms
61a1a2b3fdf32536035a5559fda92e54c7065f68 1222.73 ms 1245.35 ms 22.62 ms
add8416cd7e3d0f3e9234f9d747c185a8b55be55 1270.72 ms 1300.38 ms 29.66 ms
98713e686d91e6b883edd404dc9b7dbc982abf67 1211.48 ms 1244.42 ms 32.94 ms
8f397a72ebc82923bd173410e0902c7cd70c7ba0 1196.55 ms 1226.82 ms 30.27 ms
90d17d3377ae86c2e4701219719ae696fd19a4ac 1261.18 ms 1278.18 ms 17.00 ms
253bb7145527585db28fe308f7eeeef63cd1266a 1221.62 ms 1250.82 ms 29.20 ms
a2af9fa74a3c0df1a354d258f96f9871f28a3985 1236.62 ms 1253.12 ms 16.50 ms
effc81c914315e442c8799bf25a234be678a25b5 1253.71 ms 1256.16 ms 2.45 ms

App size

Revision Plain With Sentry Diff
1e065bcccc0572b03c44fa943cd9e6080e42c820 20.76 KiB 425.78 KiB 405.01 KiB
6f4d20cfd596b993e8ef9c1ebdeb5c835cb612be 20.76 KiB 431.71 KiB 410.95 KiB
61a1a2b3fdf32536035a5559fda92e54c7065f68 21.58 KiB 424.34 KiB 402.76 KiB
add8416cd7e3d0f3e9234f9d747c185a8b55be55 21.58 KiB 541.91 KiB 520.33 KiB
98713e686d91e6b883edd404dc9b7dbc982abf67 20.76 KiB 435.22 KiB 414.46 KiB
8f397a72ebc82923bd173410e0902c7cd70c7ba0 20.76 KiB 420.55 KiB 399.79 KiB
90d17d3377ae86c2e4701219719ae696fd19a4ac 20.76 KiB 432.17 KiB 411.41 KiB
253bb7145527585db28fe308f7eeeef63cd1266a 20.76 KiB 393.37 KiB 372.60 KiB
a2af9fa74a3c0df1a354d258f96f9871f28a3985 20.76 KiB 432.87 KiB 412.11 KiB
effc81c914315e442c8799bf25a234be678a25b5 20.76 KiB 433.18 KiB 412.42 KiB

Previous results on branch: feat(SR)/averagecolormasking

Startup times

Revision Plain With Sentry Diff
e3a04fb32db35d2a082ba2ad39d3be8c687450f3 1222.72 ms 1244.85 ms 22.13 ms
6b8b5ea9ba80ee645b4a9704df6cfe145f19e192 1240.14 ms 1255.67 ms 15.52 ms

App size

Revision Plain With Sentry Diff
e3a04fb32db35d2a082ba2ad39d3be8c687450f3 21.58 KiB 621.03 KiB 599.45 KiB
6b8b5ea9ba80ee645b4a9704df6cfe145f19e192 21.58 KiB 619.21 KiB 597.62 KiB

github-actions[bot] avatar Apr 25 '24 13:04 github-actions[bot]

hope we can ship this one Monday to unblock customers trialing who are affected by high CPU

bruno-garcia avatar May 04 '24 00:05 bruno-garcia