sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

8.24.0 compile error missing swift classes miss public keyword

Open RayFor24 opened this issue 1 year ago • 5 comments

Platform

iOS

Environment

Develop

Installed

CocoaPods

Version

8.24.0

Did it work on previous versions?

No response

Steps to Reproduce

const char *viewClassName = [[SwiftDescriptor getObjectClassName:view] UTF8String]; error: No known class method for selector 'getObjectClassName:'

After introducing 8.24.0, compile the error that the project report method cannot find. The project previously referenced version 8.22.0 without this error. After comparison, it was found that some swift classes were missing the public keyword, such as SwiftDescriptor, HTTPHeaderSanitizer, and so on.

Expected Result

const char *viewClassName = [[SwiftDescriptor getObjectClassName:view] UTF8String]; error: No known class method for selector 'getObjectClassName:'

Actual Result

const char *viewClassName = [[SwiftDescriptor getObjectClassName:view] UTF8String]; error: No known class method for selector 'getObjectClassName:'

Are you willing to submit a PR?

No response

RayFor24 avatar Apr 12 '24 03:04 RayFor24

Hello @RayFor24, thanks for reaching out. Are you trying to use SwiftDescriptor into your project, or are these errors happening inside Sentry codebase?

brustolin avatar Apr 12 '24 06:04 brustolin

Hello @RayFor24, thanks for reaching out. Are you trying to use SwiftDescriptor into your project, or are these errors happening inside Sentry codebase?

I don't want to use SwiftDescriptor in my project, happening inside Sentry codebase.

RayFor24 avatar Apr 15 '24 03:04 RayFor24

Hey @RayFor24 thanks for confirming, we'll investigate and follow up here

kahest avatar Apr 15 '24 08:04 kahest

@RayFor24 would you be able to provide a minimal repro? we're not able to reproduce this with our samples

kahest avatar Apr 17 '24 12:04 kahest

Related issue via RN SDK: https://github.com/getsentry/sentry-react-native/issues/3765

kahest avatar Apr 23 '24 13:04 kahest

Hello @RayFor24 do you have any configuration on your pods file that disable "APPLICATION_EXTENSION_API_ONLY" for the pods you're using?

Can you share your pod file with us in case it does not contains any private information?

brustolin avatar May 07 '24 17:05 brustolin

@brustolin A users responded in https://github.com/getsentry/sentry-react-native/issues/3765 it was caused by the APPLICATION_EXTENSION_API_ONLY flag set to NO.

krystofwoldrich avatar May 17 '24 10:05 krystofwoldrich

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Jun 08 '24 07:06 getsantry[bot]