sentry-cocoa
sentry-cocoa copied to clipboard
[Updated] added Change to support socks proxy or private session configuration.
…on configuration. #skip-changelog
:scroll: Description
- We are a current customer of sentry, and we use custom socks proxy on our end, we have no way to set up socks proxy for sentry services. we have added change to provide hook with URL Session.
:bulb: Support Socks proxy and private session configuration with custom SSL Certs.
- Solve Custom SSL pinning
- Provide support Socks Proxy
:green_heart: How did you test it?
:pencil: Checklist
You have to check all boxes before merging:
- [x] I reviewed the submitted code.
- [x] I added tests to verify the changes.
- [x] No new PII added or SDK only sends newly added PII if
sendDefaultPII
is enabled. - [ ] I updated the docs if needed.
- x ] Review from the native team if needed.
- [X] No breaking change or entry added to the changelog.
- [X] No breaking change for hybrid SDKs or communicated to hybrid SDKs.
:crystal_ball: Next steps
- Added unit tests around new options for urlSession
- updated
- (BOOL)validateOptions:(NSDictionary<NSString *, id> *)options didFailWithError:(NSError *_Nullable *_Nullable)error
- new property description been added as well.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.743%. Comparing base (
523915a
) to head (4a7084e
).
Additional details and impacted files
@@ Coverage Diff @@
## main #3811 +/- ##
=============================================
- Coverage 90.761% 90.743% -0.019%
=============================================
Files 586 586
Lines 45754 45783 +29
Branches 16335 16333 -2
=============================================
+ Hits 41527 41545 +18
- Misses 4047 4168 +121
+ Partials 180 70 -110
Files | Coverage Δ | |
---|---|---|
Sources/Sentry/SentryOptions.m | 99.195% <100.000%> (+0.004%) |
:arrow_up: |
Sources/Sentry/SentryTransportFactory.m | 100.000% <100.000%> (ø) |
|
...Tests/Networking/SentryTransportFactoryTests.swift | 100.000% <100.000%> (ø) |
|
Tests/SentryTests/SentryOptionsTest.m | 98.619% <100.000%> (+0.012%) |
:arrow_up: |
... and 30 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 523915a...4a7084e. Read the comment docs.
@philipphofmann Please get this approved, All checks are complete, we do need these changes next release version.
Fix up compiler error