sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

ref: Uncouple DependencyContainer from SentryHub

Open brustolin opened this issue 11 months ago • 2 comments

Removed SentryHub dependency from SentryDependencyContainer to avoid cyclic reference that caused a problem in this PR.

#skip-changelog

brustolin avatar Mar 01 '24 13:03 brustolin

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1227.96 ms 1255.23 ms 27.27 ms
Size 21.58 KiB 424.43 KiB 402.85 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3f366ee274433a5eee44c472050832d520036638 1242.28 ms 1260.80 ms 18.52 ms
fc163f589106843d00b24c410c9a32634865a9c1 1224.17 ms 1248.24 ms 24.08 ms
e8b11f82113111c9b90d05cae5a01bac4c00b109 1233.66 ms 1249.74 ms 16.08 ms
8636ef0dc734ff0de869e85a6017411a6c2836d1 1239.96 ms 1253.14 ms 13.18 ms
fcde0458edf56bb4875cdd7878339bc81dfb0fcb 1260.71 ms 1275.00 ms 14.29 ms
f8833c443d047f0c8dac5710e52b4c0624fc52ce 1236.45 ms 1252.82 ms 16.37 ms
28c80b59548404a5a9be2a767fc18a1ebbe2d5b4 1198.63 ms 1214.08 ms 15.45 ms
dd0557fb0fec40f5527e4f40ead6f82e092fde0f 1246.31 ms 1258.46 ms 12.15 ms
60dd0f5656d961f9a9d604ceaf8dd5d99efd393d 1247.35 ms 1267.59 ms 20.24 ms
e0f077c32b92169e5d4ad45e0c0a4ae6bbc2a74b 1224.65 ms 1243.52 ms 18.87 ms

App size

Revision Plain With Sentry Diff
3f366ee274433a5eee44c472050832d520036638 20.76 KiB 427.84 KiB 407.08 KiB
fc163f589106843d00b24c410c9a32634865a9c1 20.76 KiB 436.30 KiB 415.54 KiB
e8b11f82113111c9b90d05cae5a01bac4c00b109 22.85 KiB 411.92 KiB 389.07 KiB
8636ef0dc734ff0de869e85a6017411a6c2836d1 22.84 KiB 403.18 KiB 380.34 KiB
fcde0458edf56bb4875cdd7878339bc81dfb0fcb 20.76 KiB 435.26 KiB 414.50 KiB
f8833c443d047f0c8dac5710e52b4c0624fc52ce 21.58 KiB 422.66 KiB 401.08 KiB
28c80b59548404a5a9be2a767fc18a1ebbe2d5b4 21.58 KiB 417.85 KiB 396.27 KiB
dd0557fb0fec40f5527e4f40ead6f82e092fde0f 22.85 KiB 411.75 KiB 388.90 KiB
60dd0f5656d961f9a9d604ceaf8dd5d99efd393d 20.76 KiB 393.37 KiB 372.60 KiB
e0f077c32b92169e5d4ad45e0c0a4ae6bbc2a74b 22.85 KiB 412.59 KiB 389.74 KiB

Previous results on branch: ref/dependencycontainer-without-hub

Startup times

Revision Plain With Sentry Diff
85c4ec291db2260442ce6ae5cc79954467c468e8 1235.57 ms 1251.47 ms 15.90 ms

App size

Revision Plain With Sentry Diff
85c4ec291db2260442ce6ae5cc79954467c468e8 21.58 KiB 424.48 KiB 402.89 KiB

github-actions[bot] avatar Mar 01 '24 13:03 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.248%. Comparing base (61a1a2b) to head (84c7a3d). Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3698       +/-   ##
=============================================
- Coverage   89.287%   89.248%   -0.039%     
=============================================
  Files          534       534               
  Lines        58940     58952       +12     
  Branches     21153     21158        +5     
=============================================
- Hits         52626     52614       -12     
- Misses        5280      5300       +20     
- Partials      1034      1038        +4     
Files Coverage Δ
Sources/Sentry/SentryDependencyContainer.m 95.402% <100.000%> (+0.071%) :arrow_up:
Sources/Sentry/SentrySDK.m 90.977% <100.000%> (+0.034%) :arrow_up:
...erformance/Network/SentryNetworkTrackerTests.swift 97.183% <100.000%> (+0.003%) :arrow_up:
...ions/SentryCrash/SentryCrashIntegrationTests.swift 84.684% <100.000%> (+0.092%) :arrow_up:
Tests/SentryTests/SentrySDKTests.swift 97.560% <100.000%> (+0.007%) :arrow_up:

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61a1a2b...84c7a3d. Read the comment docs.

codecov[bot] avatar Mar 01 '24 14:03 codecov[bot]