sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

feat(Session Replay): Session Replay Integration

Open brustolin opened this issue 1 year ago • 3 comments

:scroll: Description

Adding Session replay integration

:bulb: Motivation and Context

:green_heart: How did you test it?

:pencil: Checklist

You have to check all boxes before merging:

  • [ ] I reviewed the submitted code.
  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

#skip-changelog

brustolin avatar Feb 20 '24 16:02 brustolin

Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against 1f8f703ff6c7e3c92a696b61d42bfd76b357afa6

github-actions[bot] avatar Feb 20 '24 16:02 github-actions[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1237.52 ms 1252.94 ms 15.42 ms
Size 21.58 KiB 579.56 KiB 557.98 KiB

Baseline results on branch: feat/session-replay

Startup times

Revision Plain With Sentry Diff
0de47cc19557f389e7c3fab58428f6ca45b7274f 1219.55 ms 1245.96 ms 26.41 ms
4b9294426980f696836a8b2716716c69b7b4f68a 1236.31 ms 1254.06 ms 17.76 ms

App size

Revision Plain With Sentry Diff
0de47cc19557f389e7c3fab58428f6ca45b7274f 21.58 KiB 549.65 KiB 528.06 KiB
4b9294426980f696836a8b2716716c69b7b4f68a 21.58 KiB 547.02 KiB 525.44 KiB

Previous results on branch: feat(SR)/replay-integration

Startup times

Revision Plain With Sentry Diff
a90f1adc658a22f5b8feb1c28cfde43cd8cb31a5 1218.00 ms 1236.04 ms 18.04 ms
f578a857958563332c5e05b89f741a38dcf9f2bc 1196.49 ms 1211.60 ms 15.11 ms
e0754d574fabfaa847d821f62e78629121f279a7 1235.65 ms 1252.04 ms 16.39 ms
dd0183298107d59ed848053601a2919ffd6d3066 1214.80 ms 1227.48 ms 12.68 ms
0ab9fa31f59d39a45d4d2b01e23da9c484e51e17 1231.39 ms 1252.20 ms 20.82 ms
dd705a912460dbaea149eaf4860afacac88960ff 1202.49 ms 1225.38 ms 22.89 ms
305cf665cd7fe48753c1a0cdbbfdc9c082e8fb66 1201.24 ms 1217.76 ms 16.51 ms
c203967fe98f3f4c6327903dbdb34fc8a4011165 1208.16 ms 1225.16 ms 17.00 ms
65442f46d2896b149402172f3453a9e77da8618f 1226.58 ms 1240.06 ms 13.48 ms
6ce4076c4f80da83f12da353e4ff53cd81ff7d6a 1237.80 ms 1250.39 ms 12.59 ms

App size

Revision Plain With Sentry Diff
a90f1adc658a22f5b8feb1c28cfde43cd8cb31a5 21.58 KiB 577.42 KiB 555.84 KiB
f578a857958563332c5e05b89f741a38dcf9f2bc 21.58 KiB 433.83 KiB 412.25 KiB
e0754d574fabfaa847d821f62e78629121f279a7 21.58 KiB 576.65 KiB 555.07 KiB
dd0183298107d59ed848053601a2919ffd6d3066 21.58 KiB 576.64 KiB 555.05 KiB
0ab9fa31f59d39a45d4d2b01e23da9c484e51e17 21.58 KiB 576.60 KiB 555.01 KiB
dd705a912460dbaea149eaf4860afacac88960ff 21.58 KiB 440.43 KiB 418.85 KiB
305cf665cd7fe48753c1a0cdbbfdc9c082e8fb66 21.58 KiB 440.48 KiB 418.90 KiB
c203967fe98f3f4c6327903dbdb34fc8a4011165 21.58 KiB 439.79 KiB 418.21 KiB
65442f46d2896b149402172f3453a9e77da8618f 21.58 KiB 576.63 KiB 555.05 KiB
6ce4076c4f80da83f12da353e4ff53cd81ff7d6a 21.58 KiB 576.86 KiB 555.28 KiB

github-actions[bot] avatar Feb 20 '24 16:02 github-actions[bot]

Codecov Report

Attention: Patch coverage is 59.38804% with 292 lines in your changes are missing coverage. Please review.

Project coverage is 88.766%. Comparing base (87d0133) to head (1a1405f).

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##           feat/session-replay     #3671       +/-   ##
=========================================================
- Coverage               89.346%   88.766%   -0.580%     
=========================================================
  Files                      546       554        +8     
  Lines                    59650     60141      +491     
  Branches                 21416     21526      +110     
=========================================================
+ Hits                     53295     53385       +90     
- Misses                    5310      5749      +439     
+ Partials                  1045      1007       -38     
Files Coverage Δ
SentryTestUtils/TestTransport.swift 81.250% <ø> (ø)
Sources/Sentry/SentryBaseIntegration.m 96.350% <ø> (+7.299%) :arrow_up:
Sources/Sentry/SentryClient.m 95.312% <100.000%> (-0.166%) :arrow_down:
Sources/Sentry/SentryDateUtil.m 100.000% <100.000%> (ø)
Sources/Sentry/SentryOptions.m 97.708% <100.000%> (+0.014%) :arrow_up:
Sources/Sentry/SentryReplayEvent.m 100.000% <100.000%> (ø)
...t/Integrations/SessionReplay/SentryVideoInfo.swift 100.000% <100.000%> (ø)
...rations/SessionReplay/SentryReplayEventTests.swift 100.000% <100.000%> (ø)
...onReplay/SentrySessionReplayIntegrationTests.swift 100.000% <100.000%> (ø)
SentryTestUtils/TestCurrentDateProvider.swift 82.051% <0.000%> (-7.693%) :arrow_down:
... and 8 more

... and 70 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87d0133...1a1405f. Read the comment docs.

codecov[bot] avatar Mar 27 '24 11:03 codecov[bot]

CI errors in the PR will be fixed in the next one: https://github.com/getsentry/sentry-cocoa/pull/3816

brustolin avatar Apr 05 '24 12:04 brustolin