sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

Speed up attachStacktrace

Open brustolin opened this issue 2 years ago • 2 comments

Description

Following #2573, refactor SentryStacktraceBuilder or sentrycrashsymbolicator_symbolicate to use dladdr.

See this discussion

brustolin avatar Jan 13 '23 08:01 brustolin

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Feb 04 '23 00:02 github-actions[bot]

Using dladdr is way faster than using our own version of dladdr, which is async safe and we only need when the application is crashes.

This could blow up easily and therefore we need to ensure that this change doesn't introduce any major bugs.

philipphofmann avatar Feb 08 '23 13:02 philipphofmann

Done in https://github.com/getsentry/sentry-cocoa/pull/6562 since we removed dladdr

noahsmartin avatar Nov 18 '25 16:11 noahsmartin