sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

Use `paths-filter` action in CI

Open armcknight opened this issue 3 years ago • 3 comments

Description

The missing functionality GitHub should have for its workflow triggers: https://github.com/getsentry/paths-filter

This will cut down on a lot of wasted compute time, and headaches with flaky tests failing when it’s not even necessary to run them.

armcknight avatar Oct 31 '22 18:10 armcknight

Im curious to know where would this help? Do you have any scenarios in mind?

IMO, If we need a job or step to run with a specific path filter we could create a different workflow, no need to use another github action.

brustolin avatar Jun 20 '23 08:06 brustolin

I thought

  pull_request:
    paths:

was meant for this.

brustolin avatar Jan 05 '24 12:01 brustolin

Sorry I didn't see your earlier message from some time ago. Check this out: https://github.com/dorny/paths-filter/issues/107#issuecomment-954215848

armcknight avatar Jan 18 '24 01:01 armcknight

I tried using path-filters in https://github.com/getsentry/sentry-cocoa/pull/3887 and it turns out it's a bit more complicated than using GH actions builtin paths:. As we don't have any required checks the advantage described in https://github.com/dorny/paths-filter/issues/107#issuecomment-954215848 doesn't apply to our repository. I think we can continue using GH actions builtin paths: instead to optimize our CI. We can close this.

philipphofmann avatar Apr 24 '24 11:04 philipphofmann