sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

Support `hints`

Open marandaneto opened this issue 3 years ago • 6 comments

Description

This is needed for https://github.com/getsentry/sentry-cocoa/issues/1460 and https://github.com/getsentry/sentry-cocoa/issues/2650 Also for https://develop.sentry.dev/sdk/features/#http-client-errors -> PR Hints are part of the Unified API. Hints are generally a Map<String, Any>, on Java leverage the data bag with a typed class with helper methods.

marandaneto avatar Oct 25 '22 07:10 marandaneto

If we add an overload for beforeSend with a hint we can do this without a breaking change.

philipphofmann avatar Oct 27 '22 13:10 philipphofmann

On Java, we have typed hints. I think that would be better than having a Map<String, Any>.

philipphofmann avatar Jul 18 '23 09:07 philipphofmann

On Java, we have typed hints. I think that would be better than having a Map<String, Any>.

Yes, it used to be a Map, now it is a typed Hint, which is better.

marandaneto avatar Jul 18 '23 10:07 marandaneto

Hints must allow capturing stacktraces only for one event if capture stacktraces is disabled in the options, as requested in https://github.com/getsentry/sentry-cocoa/issues/3386.

philipphofmann avatar Nov 08 '23 13:11 philipphofmann

Thanks, @philipphofmann! Can you expand a little bit more on how much of a priority this is from Sentry's point of view and what should we expect in terms of timeline? 🙏

marcelofabri avatar Nov 08 '23 18:11 marcelofabri

@marcelofabri We bumped the priority because we have more data points that hints would be a useful addition for some use cases. We don't plan to tackle this within the next few weeks at the moment so don't have a specific timeline, but we'd want to land this within the next months.

kahest avatar Nov 09 '23 10:11 kahest