sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

Disable ANR detection in benchmarks

Open vaind opened this issue 3 years ago • 7 comments

Description

There are a lot of issues per day (~3.3k for the last 24 hours) seemingly related to benchmarks. I'd suggest disabling ANR detection in the benchmark run. See https://sentry.io/organizations/sentry-sdks/projects/sentry-cocoa/?issuesType=all&project=5428557&statsPeriod=24h

Besides the obvious number of issues, there is also about 250 KB of attachments associated with each issue, totalling about 800 MB per day, which are pretty useless in those issues.

cc @armcknight

vaind avatar Jul 12 '22 10:07 vaind

We discussed a flag to control the "quality" of screenshots. It seems we need that already for ourselves. We already ran out of quota. I wonder if we should add a "low" quality option to be a fraction of the current one and use that instead. Current quality/size can be default.

bruno-garcia avatar Jul 12 '22 11:07 bruno-garcia

that's actually not a screenshot but some additional attachment. I assume that's added to the scope automatically in the sample used to run benchmarks...

vaind avatar Jul 12 '22 12:07 vaind

We already ran out of quota

yeah... I found out the hard way last week when I was trying to set up the nativescreenshot attachment in Unity not getting anything reported to sentry.io, not even dotnet screenshots that worked before... trying to track when it stopped working, etc... only to find out later that the project has hit the quota, so the attachments were dropped silently.

vaind avatar Jul 12 '22 12:07 vaind

Thanks for pointing this out, @vaind. It totally makes sense.

philipphofmann avatar Jul 12 '22 15:07 philipphofmann

Added it to the current benchmarking update omnibus PR 😄

armcknight avatar Jul 12 '22 20:07 armcknight

So this will be fixed by https://github.com/getsentry/sentry-cocoa/pull/1926, @armcknight?

philipphofmann avatar Jul 13 '22 08:07 philipphofmann

Correct.

armcknight avatar Jul 13 '22 08:07 armcknight

resolved by https://github.com/getsentry/sentry-cocoa/pull/1926/files#diff-489e20902b3b8cb67d406ba71c59e123294eead63461fd69a475859ad75a6309R31-R37

vaind avatar Oct 03 '22 11:10 vaind