sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

Automatically trace `CAAnimationDelegate` start/stop methods

Open armcknight opened this issue 3 years ago • 3 comments

Problem Statement

It could be helpful for developers to be made aware of degraded performance of animations they build using Core Animation. We could use our automatic instrumentation to start and stop a span on animationDidStart:/animationDidStop: towards this end.

Solution Brainstorm

We could examine the classes delivered in an application binary and check to see if they conform to the CAAminationDelegate protocol and then swizzle animationDidStart:/animationDidStop: to create the span.

armcknight avatar Jun 15 '22 12:06 armcknight

The use case for this is to determine if your animations cause glitches. If we added spans for animations, this wouldn't help much because you don't know which span had glitches. It would make sense to add the amount of total, slow and frozen frames to spans, see https://github.com/getsentry/sentry-cocoa/issues/1912

Most animations won't happen for auto-generated UIViewController transactions, but instead for UI event transactions.

Consider repeating animations without an end.

Related to https://github.com/getsentry/sentry-cocoa/issues/1843 and https://github.com/getsentry/team-mobile/issues/4

philipphofmann avatar Jun 22 '22 13:06 philipphofmann

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Jul 21 '22 00:07 github-actions[bot]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Aug 12 '22 00:08 github-actions[bot]