sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

Don't invoke beforeSend for transactions

Open philipphofmann opened this issue 3 years ago • 3 comments

Description

The SDK must not invoke beforeSend for transactions. If users want to drop transactions, they should instead use event processors, see https://develop.sentry.dev/sdk/performance/#interaction-with-beforesend-and-event-processors

As some users might rely on calling beforeSend to drop transactions and event processors are not public, this change is a breaking change. Please remember that some users could also use beforeSend to send transactions to another endpoint, so we have to provide an alternative.

philipphofmann avatar Mar 29 '22 13:03 philipphofmann

@philipphofmann please let me know if we fix this

ndmanvar avatar Apr 12 '22 18:04 ndmanvar

@ndmanvar, we can only fix this with a major version as pointed out above

As some users might rely on calling beforeSend to drop transactions and event processors are not public, this change is a breaking change. Please remember that some users could also use beforeSend to send transactions to another endpoint, so we have to provide an alternative.

So when we are going to fix this, we make sure to not break anybody.

philipphofmann avatar Apr 12 '22 18:04 philipphofmann

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar May 04 '22 00:05 github-actions[bot]